Skip to content

Comments

fix: prometheus multproc dir permissions error#120

Merged
matthewelwell merged 23 commits intomainfrom
fix/os-dir-permissions-generic-util-version
Nov 11, 2025
Merged

fix: prometheus multproc dir permissions error#120
matthewelwell merged 23 commits intomainfrom
fix/os-dir-permissions-generic-util-version

Conversation

@matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Nov 10, 2025

This is another implementation of #118 .

Whereas #118 keeps everything well organised in the prometheus package, at the expense of adding complexity to prometheus.__init__, this PR opts for a more simple, but perhaps more crude approach by just implementing all of the logic in the core package.

@matthewelwell matthewelwell requested a review from a team as a code owner November 10, 2025 19:39
@matthewelwell matthewelwell requested review from emyller and khvn26 and removed request for a team and emyller November 10, 2025 19:39
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.65%. Comparing base (4897567) to head (051d617).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   94.63%   94.65%   +0.02%     
==========================================
  Files          77       77              
  Lines        2459     2471      +12     
==========================================
+ Hits         2327     2339      +12     
  Misses        132      132              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

khvn26
khvn26 previously approved these changes Nov 10, 2025
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks cleaner and more maintainable than #118, but we need to fix coverage.

@matthewelwell
Copy link
Contributor Author

This looks cleaner and more maintainable than #118, but we need to fix coverage.

Coverage sorted.

@matthewelwell matthewelwell merged commit 51d9c9a into main Nov 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants