Skip to content

Comments

deps: bump flagsmith-common from 2.2.4 to 2.2.5#6256

Closed
matthewelwell wants to merge 18 commits intomainfrom
deps/update-flagsmith-common-2.2.5
Closed

deps: bump flagsmith-common from 2.2.4 to 2.2.5#6256
matthewelwell wants to merge 18 commits intomainfrom
deps/update-flagsmith-common-2.2.5

Conversation

@matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Nov 7, 2025

Changes

Update flagsmith-common from 2.2.4 to 2.2.6.

Contributes to #5990 and resolves this Sentry issue.

See the following PRs in flagsmith-common for more context.

Flagsmith/flagsmith-common#118
Flagsmith/flagsmith-common#120

How did you test this code?

Tested in flagsmith-common repo.

@matthewelwell matthewelwell requested a review from a team as a code owner November 7, 2025 16:55
@matthewelwell matthewelwell requested review from Zaimwa9 and removed request for a team November 7, 2025 16:55
@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Preview Nov 10, 2025 8:12pm
flagsmith-frontend-preview Ignored Ignored Preview Nov 10, 2025 8:12pm
flagsmith-frontend-staging Ignored Ignored Preview Nov 10, 2025 8:12pm

@matthewelwell matthewelwell requested review from khvn26 and removed request for Zaimwa9 November 7, 2025 16:55
@github-actions github-actions bot added the api Issue related to the REST API label Nov 7, 2025
@khvn26 khvn26 changed the title deps: update flagsmith-common 2.2.5 deps: bump flagsmith-common from 2.2.4 to 2.2.5 Nov 7, 2025
khvn26
khvn26 previously approved these changes Nov 7, 2025
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanted to type /lgtm

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-6256 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6256 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-6256 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-6256 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6256 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6256 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6256 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6256 Finished ✅ Results

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.01%. Comparing base (00b1e90) to head (7f8d0ad).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6256   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files        1278     1278           
  Lines       45183    45183           
=======================================
  Hits        44285    44285           
  Misses        898      898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewelwell
Copy link
Contributor Author

matthewelwell commented Nov 7, 2025

A snippet of the traceback from the CI failure here:

  flagsmith-api-1  | PermissionError: [Errno 13] Permission denied: '/tmp/flagsmith-prometheus/gauge_livemax_1.db'

This indicates to me that there's something wrong in the creation of the directory (as done here, by our own process now) which means that the prometheus process is unable to write to it.

Looking at this thread might give us some answers.

I'm going to continue investigating.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 7, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 7, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 7, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 7, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 10, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 10, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

djangorestframework-dataclasses = "^1.3.1"
pyotp = "^2.9.0"
flagsmith-common = "^2.2.4"
flagsmith-common = { git = "https://github.com/flagsmith/flagsmith-common", branch = "fix/os-dir-permissions" }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unstable Dependencies Break Build Reproducibility

The dependency points to a mutable git branch fix/os-dir-permissions instead of a version tag, despite the PR claiming to bump to version 2.2.5. This creates non-reproducible builds since the branch content can change without notice, and different installations could receive different code. The dependency should reference a specific version tag or commit hash for reproducibility.

Fix in Cursor Fix in Web

@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 10, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 10, 2025
djangorestframework-dataclasses = "^1.3.1"
pyotp = "^2.9.0"
flagsmith-common = "^2.2.4"
flagsmith-common = { git = "https://github.com/flagsmith/flagsmith-common", branch = "fix/os-dir-permissions" }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Conflicting Dependency Sources Block Installation

The flagsmith-common dependency is declared twice with conflicting sources: once in main dependencies as a git branch (line 166) and once in dev dependencies with a version constraint and extras (line 250). Poetry cannot resolve conflicting dependency sources for the same package, which will cause installation failures or unpredictable behavior. The dev dependency declaration needs to either use the same git source with extras or be removed if the git source already provides the needed functionality.

Fix in Cursor Fix in Web

@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 10, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 10, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 10, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 10, 2025
djangorestframework-dataclasses = "^1.3.1"
pyotp = "^2.9.0"
flagsmith-common = "^2.2.4"
flagsmith-common = { git = "https://github.com/flagsmith/flagsmith-common", branch = "fix/os-dir-permissions" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to use a tagged version.

@matthewelwell
Copy link
Contributor Author

Superseded by #6267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants