Skip to content

deps: bump flagsmith-common from 2.2.4 to 2.2.5 #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthewelwell wants to merge 18 commits into from
Closed

deps: bump flagsmith-common from 2.2.4 to 2.2.5 #6256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0cf407f
Update flagsmith-common
matthewelwell Nov 7, 2025
03ad2f5
temp: use repo flagsmith-common
matthewelwell Nov 7, 2025
e63928f
Update source reference
matthewelwell Nov 7, 2025
50c1abc
Update flagsmith-common git sha
matthewelwell Nov 7, 2025
e780dc6
Update flagsmith-common git sha
matthewelwell Nov 7, 2025
a167e76
Update flagsmith-common git sha
matthewelwell Nov 7, 2025
7b3f69d
Update flagsmith-common git sha
matthewelwell Nov 7, 2025
3866828
Update flagsmith-common git sha
matthewelwell Nov 10, 2025
d2f248a
Update flagsmith-common git sha
matthewelwell Nov 10, 2025
6ad6e54
Update flagsmith-common git sha
matthewelwell Nov 10, 2025
be15c76
Update flagsmith-common git sha
matthewelwell Nov 10, 2025
4f744f2
Add `setupprometheusmultiproc`
matthewelwell Nov 10, 2025
b01b811
Add `setupprometheusmultiproc` to run-task-processor too
matthewelwell Nov 10, 2025
71a4e38
revert run-docker changes in favour of python code in latest flagsmit…
matthewelwell Nov 10, 2025
2a09ee7
Update flagsmith-common sha
matthewelwell Nov 10, 2025
954a1f5
Update flagsmith-common sha
matthewelwell Nov 10, 2025
1bd95a5
Update flagsmith-common sha
matthewelwell Nov 10, 2025
7f8d0ad
Update flagsmith-common sha
matthewelwell Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 12 additions & 29 deletions api/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ pygithub = "2.1.1"
hubspot-api-client = "^8.2.1"
djangorestframework-dataclasses = "^1.3.1"
pyotp = "^2.9.0"
flagsmith-common = "^2.2.4"
flagsmith-common = { git = "https://github.com/flagsmith/flagsmith-common", branch = "fix/os-dir-permissions" }
Copy link

@cursor cursor bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unstable Dependencies Break Build Reproducibility

The dependency points to a mutable git branch fix/os-dir-permissions instead of a version tag, despite the PR claiming to bump to version 2.2.5. This creates non-reproducible builds since the branch content can change without notice, and different installations could receive different code. The dependency should reference a specific version tag or commit hash for reproducibility.

Fix in Cursor Fix in Web

Copy link

@cursor cursor bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Conflicting Dependency Sources Block Installation

The flagsmith-common dependency is declared twice with conflicting sources: once in main dependencies as a git branch (line 166) and once in dev dependencies with a version constraint and extras (line 250). Poetry cannot resolve conflicting dependency sources for the same package, which will cause installation failures or unpredictable behavior. The dev dependency declaration needs to either use the same git source with extras or be removed if the git source already provides the needed functionality.

Fix in Cursor Fix in Web

Copy link
Contributor

@emyller emyller Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to use a tagged version.

django-stubs = "^5.1.3"
tzdata = "^2024.1"
djangorestframework-simplejwt = "^5.5.1"
Expand Down
1 change: 0 additions & 1 deletion api/scripts/run-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ waitfordb() {
python manage.py waitfordb "$@"
fi
}

migrate () {
waitfordb \
&& python manage.py showmigrations --verbosity 2 \
Expand Down
Loading