Skip to content

Conversation

@remkos
Copy link
Contributor

@remkos remkos commented Jan 2, 2025

Description of proposed changes

This updates the SCM colormaps to version 8.0.1. It effectively only adds the color map naviaW
The Section 17 of the Reference Doc was updated accordingly, with the color maps newly organised.

I noticed that the images have automatically been updated on dvc. Otherwise, they can be found here

This is in part to resolve #8653.

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@remkos remkos mentioned this pull request Jan 2, 2025
51 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified doc/scripts/images/GMT_App_M_1a.ps
modified doc/scripts/images/GMT_App_M_1b.ps
modified doc/scripts/images/GMT_App_M_1c.ps
modified doc/scripts/images/GMT_App_M_1d.ps

Image diff(s)

Details

Added images

Modified images

Path Old New
doc/scripts/images/GMT_App_M_1a.ps
doc/scripts/images/GMT_App_M_1b.ps
doc/scripts/images/GMT_App_M_1c.ps
doc/scripts/images/GMT_App_M_1d.ps

Report last updated at commit 0a1ce56

@remkos remkos added documentation Improve documentation maintenance Boring but important stuff for the core devs labels Jan 3, 2025
@remkos remkos added this to the 6.6.0 milestone Jan 3, 2025
@remkos remkos requested review from a team and removed request for a team January 3, 2025 16:17
@remkos remkos merged commit ed717e5 into master Jan 4, 2025
16 of 19 checks passed
@remkos remkos deleted the scm801 branch January 4, 2025 13:25
@seisman
Copy link
Member

seisman commented Jan 4, 2025

@remkos For unknown reasons, the two scripts GMT_App_M_1b.sh and GMT_App_M_1c.sh fail in our CI, with errors like below:

5/5 Test   #34: doc/scripts/GMT_App_M_1b.sh ......***Failed    9.33 sec
Set GMT_SESSION_NAME = 80444
ERROR: GMT_App_M_1b.sh:49
memtrack errors: 0
exit status: 1
ERROR: GMT_App_M_1b.sh:49
memtrack errors: 0
exit status: 1

Could you please do a double check?

@remkos remkos mentioned this pull request Jan 4, 2025
4 tasks
@remkos
Copy link
Contributor Author

remkos commented Jan 4, 2025

Really weird error in bash, occurring only in the test.
Fix and explanation in #8668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improve documentation maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release GMT 6.6.0

4 participants