Skip to content

Conversation

@remkos
Copy link
Contributor

@remkos remkos commented Jan 4, 2025

Description of proposed changes

Really weird. When $n == $i, this fails only in the test, it runs fine otherwise.

j1=$(expr $n - $i)

This PR bypasses this problem, introduced by #8654

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@remkos remkos requested a review from a team January 4, 2025 17:03
@remkos remkos added the bug Something isn't working label Jan 4, 2025
@remkos remkos added this to the 6.6.0 milestone Jan 4, 2025
@seisman seisman merged commit 5f62c6d into master Jan 4, 2025
2 of 5 checks passed
@seisman seisman deleted the test_fix branch January 4, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants