-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore(deps): update golang docker tag to v1.25 #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update golang docker tag to v1.25 #369
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the version of the Go runtime used within the Cloud Build configuration for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Go version used in the Cloud Build test step from 1.24 to 1.25. While this is a straightforward dependency update, it introduces an inconsistency in the Go versions used across the project. The test environment will now use Go 1.25, but the application build environment (defined in the Dockerfile) remains on Go 1.20, and the go.mod file specifies Go 1.19. To ensure consistency and prevent potential issues, I've recommended updating the Go versions in the Dockerfile and go.mod file to match the one used for testing.
| steps: | ||
| # Run tests and save to file | ||
| - name: golang:1.24 | ||
| - name: golang:1.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change updates the Go version for the test step to 1.25, but other parts of the project are using older Go versions. This can lead to inconsistencies and hard-to-debug issues.
Specifically:
- The
Dockerfileused for building the application binary (seegolang-sample/Dockerfile:18) is still ongolang:1.20-buster. It's best practice to test and build your application with the same version of Go. - The
go.modfile (golang-sample/go.mod:3) specifiesgo 1.19. It's recommended to update thegodirective to match the version of the Go toolchain you are using.
Please consider updating these other files to use Go 1.25 for consistency across your development, testing, and build environments.
This PR contains the following updates:
1.24->1.25Configuration
📅 Schedule: Branch creation - "before 8am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.