Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion golang-sample/cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# [START cloudbuild_go_test_yaml]
steps:
# Run tests and save to file
- name: golang:1.24
- name: golang:1.25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change updates the Go version for the test step to 1.25, but other parts of the project are using older Go versions. This can lead to inconsistencies and hard-to-debug issues.

Specifically:

  • The Dockerfile used for building the application binary (see golang-sample/Dockerfile:18) is still on golang:1.20-buster. It's best practice to test and build your application with the same version of Go.
  • The go.mod file (golang-sample/go.mod:3) specifies go 1.19. It's recommended to update the go directive to match the version of the Go toolchain you are using.

Please consider updating these other files to use Go 1.25 for consistency across your development, testing, and build environments.

entrypoint: /bin/bash
args:
- -c
Expand Down