chore!: drop support for old nodejs versions #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrobertson
force-pushed
the
drop-version-support
branch
2 times, most recently
from
da6812e to
988aef1
Compare
matthewrobertson
force-pushed
the
drop-version-support
branch
3 times, most recently
from
c731154 to
f9e4529
Compare
matthewrobertson
force-pushed
the
drop-version-support
branch
3 times, most recently
from
7ec14e8 to
9222ab1
Compare
This was referenced Mar 27, 2025
maemayve
approved these changes
Mar 27, 2025
Contributor
maemayve
left a comment
maemayve
left a comment
There was a problem hiding this comment.
My primary question is what evidence is there that supports the removal of typed function
matthewrobertson
force-pushed
the
drop-version-support
branch
from
9222ab1 to
b2e9f22
Compare
jama22
approved these changes
Apr 28, 2025
Contributor
jama22
left a comment
jama22
left a comment
There was a problem hiding this comment.
lgtm, ok to drop support for older nodejs as per runtime policies
This commit drops support for all Node.js versions < 18.0.0 as they are no longer supported by Cloud Run functions: https://cloud.google.com/functions/docs/runtime-support chore!: upgrade all dependencies fix!: delete the undocumented "typed" function signature
matthewrobertson
force-pushed
the
drop-version-support
branch
from
b2e9f22 to
9badc66
Compare
Contributor
|
@matthewrobertson For future Node.js bumps, I would suggest to mention the dropped Node.js version in the PR title / commit message, so it'll show up in the release notes / changelog. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit drops support for all Node.js versions < 18.0.0 as they are no longer supported by Cloud Run functions: https://cloud.google.com/functions/docs/runtime-support
chore!: upgrade all dependencies
fix!: delete the undocumented "typed" function signature