Update to MUI 3.0.4 #2868
Update to MUI 3.0.4 #2868
Conversation
…odularui.widgets.slot.ItemSlot
# Conflicts: # src/main/java/gregtech/common/metatileentities/electric/MetaTileEntityBlockBreaker.java
src/main/java/gregtech/api/mui/widget/GhostCircuitSlotWidget.java
Outdated
Show resolved
Hide resolved
| .height(1).widthRel(0.95f).margin(0, 4)) | ||
| .child(getFilter().createWidgets(guiSyncManager))) | ||
| .child(SlotGroupWidget.playerInventory().bottom(7).left(7)); | ||
| .child(SlotGroupWidget.playerInventory(false).bottom(7).left(7)); |
There was a problem hiding this comment.
This should have the player inventory displayed right? So you can set the filter from things inside the inventory?
There was a problem hiding this comment.
it does, false is just for no positioning
though it's not correct when using the filter in hand
all usages of playerInventory(false) may need .bottom(0)
|
Testing out this PR, and there is a little issue now with the ghost drag target overlay in the crafting station Item Filter GUI is messed up, player inventory seems to be in the wrong position Same with the Fluid Filter |
| .height(1).widthRel(0.95f).margin(0, 4)) | ||
| .child(getFilter().createWidgets(guiSyncManager))) | ||
| .child(SlotGroupWidget.playerInventory().bottom(7).left(7)); | ||
| .child(SlotGroupWidget.playerInventory(false).bottom(7).left(7)); |
There was a problem hiding this comment.
it does, false is just for no positioning
though it's not correct when using the filter in hand
all usages of playerInventory(false) may need .bottom(0)
src/main/java/gregtech/common/covers/filter/SimpleItemFilter.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/gregtech/api/util/JEIUtil.java
the single-block machines pr implements this, so once that gets merged it'll be easy |
ALongStringOfNumbers
left a comment
ALongStringOfNumbers
left a comment
There was a problem hiding this comment.
Hovering over the Scrolling Text Widget in the Quantum Chest turns the item slot white.
Crash while pressing e, or trying to close the GUI in an empty quantum chest. Maybe the ScrollingTextWidget needs a check if the widget is enabled before trying to close the animator.
Managed to confuse the fluid lock on the quantum tank. I had a tank locked to Distilled Water, but with no fluid inside. Used a bucket of Creosote to click on the Display Slot. The Creosote was deleted and the tank was unlocked. Then I placed a bucket of Hydrochloric Acid in the display slot, and the fluid display read Distilled Water.
| return item(() -> itemHandler.getStackInSlot(index)); | ||
| } | ||
|
|
||
| public FakeItemSlot receiveItemFromClient(@NotNull Consumer<@NotNull ItemStack> itemStackConsumer) { |
There was a problem hiding this comment.
This is unused. Was there a planned usecase for this?
There was a problem hiding this comment.
It will be for locking quantum chests to an item from a jei ghost drag.
| textWidget -> !virtualItemStack.isEmpty(), | ||
| () -> TextFormattingUtil.formatNumbers(itemsStoredInside))) | ||
| .child(new GTItemSlot() | ||
| .child(new FakeItemSlot(true) |
There was a problem hiding this comment.
Can this be just a drawable, or do we need the ItemSlot to handle ghost drags?
fix issue drawing stacks remove altText parameter
ALongStringOfNumbers
left a comment
ALongStringOfNumbers
left a comment
There was a problem hiding this comment.
Found more bugs.
In the Fluid Regulator, and maybe other covers, when you open the filter panel and pick something up from your inventory to put in the filter, you can no longer place the item back in your inventory.
Also, you cannot see the tooltips on any button while the filter panel is open.
Tooltips on fluids apply multiple times in the fluid filter panel, maybe because of the mod name tooltip thing Zorb added and some of our own stuff. It appears that whenever you open and close the filter panel, another tooltip gets appended. Doesn't happen in item filters in my testing.
Also, the mod name tooltip doesn't appear
Scrolling in filters, item and fluid, in robot arms/regulators set to the correct modes doesn't seem to do anything, whereas before it would increase/decrease amount, with key combo modifiers
Item Bus auto pull steals the item from the slot in the creative chest.
I remembered the todo in the creative handler, do you think that would be possible to refactor?
For some reason I am not seeing the scrollbar in some multiblock GUIs where I was seeing it previously
avoid potential divide be zero
fix GTFluidSlot drawing partial fluids incorrectly
(why is the default thickness -1??) also add extra line spacing after title
hide phantom slot controls if the slot is empty add todo
make fluid slot tooltip always update fix popup not closing in certain situations
prevent redundant locking use our copy method
What
Updates to the latest MUI2 RC.
Implementation Details
Removes superseded mixins.
Additional Information
There may be changes to our widgets with what's changed in RC 5 and 6 but this just gets it running.