Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
- Coverage 90.75% 90.42% -0.34%
==========================================
Files 11 11
Lines 303 303
==========================================
- Hits 275 274 -1
- Misses 28 29 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
This is not quite the same as JuliaDiff/FiniteDifferences.jl#192 |
mzgubic
approved these changes
Oct 1, 2021
Member
mzgubic
left a comment
There was a problem hiding this comment.
needs a version bump and some tests?
Member
Author
|
idk if this is a good idea or not |
Member
|
The only thing I can think of going wrong is getting a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is the behavior we want.
If you get a actual value of NaN and you were expecting a NaN then all seems well.
If both the AD rule and the finite differencing take you here all is well.
(not ok if only one does)