Fix imports of Test functions on versions >1.12#294
Closed
lkdvos wants to merge 1 commit intoJuliaDiff:mainfrom
Closed
Fix imports of Test functions on versions >1.12#294lkdvos wants to merge 1 commit intoJuliaDiff:mainfrom
lkdvos wants to merge 1 commit intoJuliaDiff:mainfrom
Conversation
|
LGTM |
|
(or #293 for a version of this that also updates CI) |
Member
|
Fixed in #293 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After JuliaLang/julia#57839, the
Test.eval_testfunction no longer exists and is split intoeval_test_comparisonandeval_test_function. This fixes the imports, such that CI tests on Julia nightly can run.It might be better to not depend on internals in the long run, but I don't currently have the time to fix this.