-
Notifications
You must be signed in to change notification settings - Fork 2
Chore/deps 15 12 25 #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/deps 15 12 25 #391
Conversation
Bumps [lucide-react](https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react) from 0.560.0 to 0.561.0. - [Release notes](https://github.com/lucide-icons/lucide/releases) - [Commits](https://github.com/lucide-icons/lucide/commits/0.561.0/packages/lucide-react) --- updated-dependencies: - dependency-name: lucide-react dependency-version: 0.561.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ucide-react-0.561.0 chore(deps): bump lucide-react from 0.560.0 to 0.561.0
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughThis PR updates multiple dependency versions across the project's package.json files and adds a Google AdSense script tag to the docs application layout with asynchronous loading and the client ID from environment variables. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 3
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| async | ||
| src={`https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=${process.env.NEXT_PUBLIC_GOOGLE_ADS_CLIENT_ID}`} | ||
| crossOrigin='anonymous' | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Google Ads script loads in all environments, not just production
The newly added Google Ads script is rendered unconditionally in all environments, while the Umami analytics script above it is wrapped in an IS_PRODUCTION check. This inconsistency means ads will load in development and preview environments, which is likely unintended and could affect ad metrics or cause development issues. The Google Ads script appears to be missing the same IS_PRODUCTION guard used for other third-party scripts.
Note
Adds a Google AdSense script to the docs layout and bumps eslint, @types/node, and lucide-react versions with corresponding lockfile updates.
<Script>inapps/docs/src/app/layout.tsxusingNEXT_PUBLIC_GOOGLE_ADS_CLIENT_ID.eslintto^9.39.2and related packages (@eslint/js,eslint-plugin-react-refresh, config/peer versions).@types/nodeto^25.0.2across root,apps/*, andpackages/react-qr-code.lucide-reactto^0.561.0inapps/docs.pnpm-lock.yamlto reflect these changes.Written by Cursor Bugbot for commit 8cc42dd. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.