Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"embla-carousel-react": "^8.6.0",
"eslint-config-next": "16.0.10",
"input-otp": "^1.4.2",
"lucide-react": "^0.560.0",
"lucide-react": "^0.561.0",
"next": "16.0.10",
"next-themes": "^0.4.6",
"prism-react-renderer": "^2.4.1",
Expand All @@ -65,7 +65,7 @@
"devDependencies": {
"@tailwindcss/postcss": "^4.1.18",
"@trivago/prettier-plugin-sort-imports": "^6.0.0",
"@types/node": "^25.0.1",
"@types/node": "^25.0.2",
"@types/react": "^19.2.7",
"@types/react-dom": "^19.2.3",
"postcss": "^8.5.6",
Expand Down
5 changes: 5 additions & 0 deletions apps/docs/src/app/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ export default function RootLayout({
data-website-id={process.env.NEXT_PUBLIC_UMAMI_WEBSITE_ID}
/>
)}
<Script
async
src={`https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=${process.env.NEXT_PUBLIC_GOOGLE_ADS_CLIENT_ID}`}
crossOrigin='anonymous'
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Google Ads script loads in all environments, not just production

The newly added Google Ads script is rendered unconditionally in all environments, while the Umami analytics script above it is wrapped in an IS_PRODUCTION check. This inconsistency means ads will load in development and preview environments, which is likely unintended and could affect ad metrics or cause development issues. The Google Ads script appears to be missing the same IS_PRODUCTION guard used for other third-party scripts.

Fix in Cursor Fix in Web

</body>
</html>
)
Expand Down
2 changes: 1 addition & 1 deletion apps/playground/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"tailwindcss": "^4.1.18"
},
"devDependencies": {
"@types/node": "^25.0.1",
"@types/node": "^25.0.2",
"@types/react": "^19.2.7",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^5.1.2",
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,19 @@
"devDependencies": {
"@changesets/changelog-github": "^0.5.2",
"@changesets/cli": "^2.29.8",
"@eslint/js": "^9.39.1",
"@eslint/js": "^9.39.2",
"@testing-library/jest-dom": "^6.9.1",
"@testing-library/react": "^16.3.0",
"@trivago/prettier-plugin-sort-imports": "^6.0.0",
"@types/jsdom": "^27.0.0",
"@types/node": "^25.0.1",
"@types/node": "^25.0.2",
"@vitejs/plugin-react": "^5.1.2",
"@vitest/coverage-v8": "4.0.15",
"concurrently": "^9.2.1",
"eslint": "^9.39.1",
"eslint": "^9.39.2",
"eslint-plugin-react": "^7.37.5",
"eslint-plugin-react-hooks": "^7.0.1",
"eslint-plugin-react-refresh": "^0.4.24",
"eslint-plugin-react-refresh": "^0.4.25",
"globals": "^16.5.0",
"husky": "^9.1.7",
"jsdom": "^27.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-qr-code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"react": "^18 || ^19"
},
"devDependencies": {
"@types/node": "^25.0.1",
"@types/node": "^25.0.2",
"@types/react": "^19.2.7",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^5.1.2",
Expand Down
Loading