Skip to content

<fix>[compute]: always submit DeleteVmGC on rollback failure regardless of GC_ELIGIBLE#3352

Open
zstack-robot-2 wants to merge 2 commits into5.5.6from
sync/ye.zou/fix/ZSTAC-68874
Open

<fix>[compute]: always submit DeleteVmGC on rollback failure regardless of GC_ELIGIBLE#3352
zstack-robot-2 wants to merge 2 commits into5.5.6from
sync/ye.zou/fix/ZSTAC-68874

Conversation

@zstack-robot-2
Copy link
Collaborator

Resolves: ZSTAC-68874

Target: 5.5.6

sync from gitlab !9181

…ss of GC_ELIGIBLE

Resolves: ZSTAC-68874

Change-Id: I19d28b38acec36b6c420fd325c1e074fae7ed2d4
@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2026

总体描述

虚拟机创建流程中的回滚处理逻辑被修改,使垃圾回收清理的提交从条件性(仅在OPERATION_FAILURE_GC_ELIGIBLE错误时)改为无条件性(在任何回滚失败时均提交)。

变化

集合 / 文件 总结
虚拟机回滚处理逻辑
compute/src/main/java/org/zstack/compute/vm/VmCreateOnHypervisorFlow.java
修改了rollback方法中的垃圾回收清理提交逻辑,将GC清理提交改为无条件执行;删除了原有的OPERATION_FAILURE_GC_ELIGIBLE条件分支;添加了GC提交的调试日志;保留了已存在GC跳过检查的逻辑。

估计审查工作量

🎯 2 (简单) | ⏱️ ~10 分钟

诗歌

🐰 垃圾要清理,无论风与雨,
回滚不侥幸,提交总要去,
逻辑更坚固,日志更清晰,
小小的改变,大大的智慧。✨


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 2 warnings)
Check name Status Explanation Resolution
Title check ❌ Error PR标题为86个字符,超过了72个字符的限制要求。 缩短标题到72个字符以内,例如:'[compute]: always submit DeleteVmGC on rollback regardless of GC_ELIGIBLE'
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (3 files):

⚔️ compute/src/main/java/org/zstack/compute/vm/VmCreateOnHypervisorFlow.java (content)
⚔️ identity/src/main/java/org/zstack/identity/QuotaUtil.java (content)
⚔️ network/src/main/java/org/zstack/network/service/DhcpExtension.java (content)

These conflicts must be resolved before merging into 5.5.6.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed PR描述与变更集相关,包含了JIRA编号和同步来源,说明了修复的意图。
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sync/ye.zou/fix/ZSTAC-68874
⚔️ Resolve merge conflicts (beta)
  • Auto-commit resolved conflicts to branch sync/ye.zou/fix/ZSTAC-68874
  • Create stacked PR with resolved conflicts
  • Post resolved changes as copyable diffs in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Resolves: ZSTAC-68874

Change-Id: I7f961d50f055bbbe441b8e4036dedfca688aeecb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants