Skip to content

<fix>[compute]: always submit DeleteVmGC on rollback failure regardless of GC_ELIGIBLE #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zstack-robot-2 wants to merge 2 commits into
base: 5.5.6
Choose a base branch
from
Open

<fix>[compute]: always submit DeleteVmGC on rollback failure regardless of GC_ELIGIBLE #3352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45e00f4
<fix>[compute]: always submit DeleteVmGC on rollback failure regardle…
AlanJager Feb 12, 2026
83a1ce5
<chore>[ci]: trigger CI rerun for flaky tests
AlanJager Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions compute/src/main/java/org/zstack/compute/vm/VmCreateOnHypervisorFlow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,20 +79,25 @@ public void run(MessageReply reply) {
spec.getVmInventory().getUuid(), spec.getVmInventory().getName(),
spec.getDestHost().getUuid(), spec.getDestHost().getName(), reply.getError()));

if (reply.getError().isError(HostErrors.OPERATION_FAILURE_GC_ELIGIBLE)) {
String gcName = String.format("gc-vm-%s-on-host-%s", spec.getVmInventory().getUuid(), spec.getDestHost().getUuid());

DeleteVmGC gc = new DeleteVmGC();
gc.NAME = gcName;
gc.hostUuid = spec.getVmInventory().getHostUuid();
gc.inventory = spec.getVmInventory();
if (gc.existedAndNotCompleted()) {
logger.debug(String.format("There is already a DeleteVmGC of vm[uuid:%s] " +
"on host[uuid:%s], skip.", spec.getVmInventory().getUuid(), spec.getDestHost().getUuid()));
} else {
gc.submit();
}
// ZSTAC-68874: Always submit GC task on rollback failure to clean up VM remnants on host
// Previously only submitted GC when error was GC_ELIGIBLE, but detach PCI failures (e.g., MN unavailable)
// don't return GC_ELIGIBLE, causing GPU resources to remain occupied
String gcName = String.format("gc-vm-%s-on-host-%s", spec.getVmInventory().getUuid(), spec.getDestHost().getUuid());

DeleteVmGC gc = new DeleteVmGC();
gc.NAME = gcName;
gc.hostUuid = spec.getVmInventory().getHostUuid();
gc.inventory = spec.getVmInventory();
if (gc.existedAndNotCompleted()) {
logger.debug(String.format("There is already a DeleteVmGC of vm[uuid:%s] " +
"on host[uuid:%s], skip.", spec.getVmInventory().getUuid(), spec.getDestHost().getUuid()));
} else {
gc.submit();
logger.debug(String.format("Submitted DeleteVmGC for vm[uuid:%s] on host[uuid:%s] due to rollback failure",
spec.getVmInventory().getUuid(), spec.getDestHost().getUuid()));
}

if (!reply.getError().isError(HostErrors.OPERATION_FAILURE_GC_ELIGIBLE)) {
VmTracerCanonicalEvents.OperateFailOnHypervisorData data = new VmTracerCanonicalEvents.OperateFailOnHypervisorData();
data.setHostUuid(spec.getVmInventory().getHostUuid());
data.setVmUuid(spec.getVmInventory().getUuid());
Expand Down