Skip to content

Conversation

@m-houston
Copy link
Contributor

Description

Adds event schemas and AsyncAPI spec for changes to letter status.

Each status has its own event, but has the same payload containing the status update (restricted to the status in question)

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@m-houston m-houston requested a review from a team as a code owner October 14, 2025 15:25
@m-houston m-houston marked this pull request as draft October 14, 2025 15:25
@m-houston
Copy link
Contributor Author

This PR is currently based on #191 so should be rebased after that is merged.

@m-houston m-houston force-pushed the feature/CCM-12352-letter-status-events branch 3 times, most recently from 8ed0161 to 4431746 Compare October 15, 2025 20:31
@m-houston m-houston mentioned this pull request Oct 17, 2025
10 tasks
@m-houston m-houston force-pushed the feature/CCM-12352-letter-status-events branch 5 times, most recently from e04025d to ce8d53e Compare October 22, 2025 15:42
@m-houston m-houston force-pushed the feature/CCM-12352-letter-status-events branch from 1753ccb to 3772317 Compare November 4, 2025 13:45
@m-houston m-houston marked this pull request as ready for review November 4, 2025 14:06
@m-houston m-houston requested a review from a team as a code owner November 4, 2025 14:06
Copy link
Contributor

@masl2 masl2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small corrections to the readme; then LGTM

@m-houston m-houston requested a review from masl2 November 5, 2025 14:18
@m-houston m-houston merged commit ae5cdd4 into main Nov 5, 2025
41 checks passed
@m-houston m-houston deleted the feature/CCM-12352-letter-status-events branch November 5, 2025 14:36
masl2 pushed a commit that referenced this pull request Jan 5, 2026
* Add event schemas for supplier-api domain

* Update event naming and metadata based on review

* Unify envelope with letter-rendering domain events using origin subject prefix

* Add group and specification IDs to letter event domain model

* Add group and specification IDs to letter event example

* Fix missing domain in origin examples

* Updates to envelope URIs and source/subject paths

* Add more examples for different statuses

* Fix linting config

* Fix linting config

* Add source field back to origin as this scopes the subject

* Update package-lock conflicts

* Regenerate schemas

* Add empty test:unit script for tests package

* CCM-12352: Remove unneeded README.md from events package

Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants