Skip to content

CCM-12949 Add campaign ID to choose templates page #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicki-nhs merged 2 commits into from
Jan 6, 2026
Merged

CCM-12949 Add campaign ID to choose templates page #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
540a6f6
CCM-12949 Add campaign ID to choose templates page
nicki-nhs Jan 5, 2026
aaf22b8
Merge branch 'main' into feature/CCM-12949-campaign-id-choose-templates
nicki-nhs Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions frontend/src/__tests__/app/choose-templates/__snapshots__/page.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ exports[`ChooseTemplatesPage renders correctly for a message plan with multiple
class="nhsuk-body-s"
>
<a
data-testid="change-message-plan-name-link"
data-testid="edit-settings-link"
href="/message-plans/edit-message-plan-settings/fbb81055-79b9-4759-ac07-d191ae57be34"
>
Change name
Edit settings
</a>
</p>
<dl
Expand All @@ -51,6 +51,21 @@ exports[`ChooseTemplatesPage renders correctly for a message plan with multiple
fbb81055-79b9-4759-ac07-d191ae57be34
</dd>
</div>
<div
class="nhsuk-summary-list__row"
>
<dt
class="nhsuk-summary-list__key"
>
Campaign
</dt>
<dd
class="nhsuk-summary-list__value monospace-font"
data-testid="campaign-id"
>
campaign-2
</dd>
</div>
<div
class="nhsuk-summary-list__row"
>
Expand Down
18 changes: 15 additions & 3 deletions frontend/src/__tests__/components/organisms/CreateEditMessagePlan.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,18 @@ describe('CreateEditMessagePlan', () => {
expect(messagePlanId).toHaveTextContent('routing-config-test');
});

it('should display the campaign ID', () => {
const plan = buildRoutingConfig();

render(
<CreateEditMessagePlan messagePlan={plan} templates={mockTemplates} />
);

const campaignId = screen.getByTestId('campaign-id');

expect(campaignId).toHaveTextContent('campaign-1');
});

it.each([
{ status: 'DRAFT' as const, display: 'Draft' },
{ status: 'COMPLETED' as const, display: 'Production' },
Expand Down Expand Up @@ -122,15 +134,15 @@ describe('CreateEditMessagePlan', () => {
expect(buttons[1].textContent).toBe('Save and close');
});

it('should render a "change name" link', () => {
it('should render an "edit settings" link', () => {
const plan = buildRoutingConfig();

render(
<CreateEditMessagePlan messagePlan={plan} templates={mockTemplates} />
);

const link = screen.getByTestId('change-message-plan-name-link');
expect(link.textContent).toBe('Change name');
const link = screen.getByTestId('edit-settings-link');
expect(link.textContent).toBe('Edit settings');
expect(link.getAttribute('href')).toBe(
`/message-plans/edit-message-plan-settings/${plan.id}`
);
Expand Down
38 changes: 34 additions & 4 deletions ...tend/src/__tests__/components/organisms/__snapshots__/CreateEditMessagePlan.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ exports[`CreateEditMessagePlan should match snapshot for a typical message plan
class="nhsuk-body-s"
>
<a
data-testid="change-message-plan-name-link"
data-testid="edit-settings-link"
href="/message-plans/edit-message-plan-settings/30fd1e1c-a608-47cf-9cc2-eabaeeeebeca"
>
Change name
Edit settings
</a>
</p>
<dl
Expand All @@ -51,6 +51,21 @@ exports[`CreateEditMessagePlan should match snapshot for a typical message plan
30fd1e1c-a608-47cf-9cc2-eabaeeeebeca
</dd>
</div>
<div
class="nhsuk-summary-list__row"
>
<dt
class="nhsuk-summary-list__key"
>
Campaign
</dt>
<dd
class="nhsuk-summary-list__value monospace-font"
data-testid="campaign-id"
>
campaign-1
</dd>
</div>
<div
class="nhsuk-summary-list__row"
>
Expand Down Expand Up @@ -756,10 +771,10 @@ exports[`CreateEditMessagePlan should match snapshot for a typical message plan
class="nhsuk-body-s"
>
<a
data-testid="change-message-plan-name-link"
data-testid="edit-settings-link"
href="/message-plans/edit-message-plan-settings/30fd1e1c-a608-47cf-9cc2-eabaeeeebeca"
>
Change name
Edit settings
</a>
</p>
<dl
Expand All @@ -780,6 +795,21 @@ exports[`CreateEditMessagePlan should match snapshot for a typical message plan
30fd1e1c-a608-47cf-9cc2-eabaeeeebeca
</dd>
</div>
<div
class="nhsuk-summary-list__row"
>
<dt
class="nhsuk-summary-list__key"
>
Campaign
</dt>
<dd
class="nhsuk-summary-list__value monospace-font"
data-testid="campaign-id"
>
campaign-1
</dd>
</div>
<div
class="nhsuk-summary-list__row"
>
Expand Down
13 changes: 12 additions & 1 deletion frontend/src/components/organisms/CreateEditMessagePlan/CreateEditMessagePlan.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export function CreateEditMessagePlan({
<h1 className='nhsuk-heading-l'>{messagePlan.name}</h1>
<p className='nhsuk-body-s'>
<Link
data-testid='change-message-plan-name-link'
data-testid='edit-settings-link'
href={interpolate(content.changeNameLink.href, {
routingConfigId: messagePlan.id,
})}
Expand All @@ -53,6 +53,17 @@ export function CreateEditMessagePlan({
{messagePlan.id}
</SummaryList.Value>
</SummaryList.Row>
<SummaryList.Row>
<SummaryList.Key>
{content.rowHeadings.campaignId}
</SummaryList.Key>
<SummaryList.Value
data-testid='campaign-id'
className='monospace-font'
>
{messagePlan.campaignId}
</SummaryList.Value>
</SummaryList.Row>
<SummaryList.Row>
<SummaryList.Key>{content.rowHeadings.status}</SummaryList.Key>
<SummaryList.Value>
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/content/content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,10 +1139,11 @@ const createEditMessagePlan = {
headerCaption: 'Message plan',
changeNameLink: {
href: '/message-plans/edit-message-plan-settings/{{routingConfigId}}',
text: 'Change name',
text: 'Edit settings',
},
rowHeadings: {
routingPlanId: 'Routing Plan ID',
campaignId: 'Campaign',
status: 'Status',
},
ctas: {
Expand Down
7 changes: 5 additions & 2 deletions tests/test-team/pages/routing/choose-templates-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ export class RoutingChooseTemplatesPage extends TemplateMgmtBasePage {

public readonly errorSummary: Locator;

public readonly changeNameLink: Locator;
public readonly editSettingsLink: Locator;

public readonly routingConfigId: Locator;

public readonly campaignId: Locator;

public readonly messagePlanStatus: Locator;

public readonly channelBlocks: Locator;
Expand All @@ -24,8 +26,9 @@ export class RoutingChooseTemplatesPage extends TemplateMgmtBasePage {
constructor(page: Page) {
super(page);
this.errorSummary = page.locator('.nhsuk-error-summary');
this.changeNameLink = page.getByTestId('change-message-plan-name-link');
this.editSettingsLink = page.getByTestId('edit-settings-link');
this.routingConfigId = page.getByTestId('routing-config-id');
this.campaignId = page.getByTestId('campaign-id');
this.messagePlanStatus = page.locator('strong.nhsuk-tag');
this.channelBlocks = page.locator('[data-testid^="message-plan-block-"]');
this.moveToProductionButton = page.getByTestId('move-to-production-cta');
Expand Down
10 changes: 8 additions & 2 deletions ...est-team/template-mgmt-routing-component-tests/choose-templates.routing-component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,10 @@ test.describe('Routing - Choose Templates page', () => {
messagePlans.valid.name
);

await expect(chooseTemplatesPage.changeNameLink).toHaveText('Change name');
await expect(chooseTemplatesPage.changeNameLink).toHaveAttribute(
await expect(chooseTemplatesPage.editSettingsLink).toHaveText(
'Edit settings'
);
await expect(chooseTemplatesPage.editSettingsLink).toHaveAttribute(
'href',
`/templates/message-plans/edit-message-plan-settings/${messagePlans.valid.id}`
);
Expand All @@ -298,6 +300,10 @@ test.describe('Routing - Choose Templates page', () => {
messagePlans.valid.id
);

await expect(chooseTemplatesPage.campaignId).toHaveText(
messagePlans.valid.campaignId
);

const messagePlanStatus =
await chooseTemplatesPage.messagePlanStatus.textContent();
expect(messagePlanStatus?.trim().toLowerCase()).toBe(
Expand Down
Loading