Skip to content

Conversation

@Bill-Becker
Copy link
Collaborator

@Bill-Becker Bill-Becker commented May 10, 2025

REopt.jl develop PR with list of feature branch PRs:

This pull request introduces several updates across multiple areas, including new financial constraints, enhancements to photovoltaic (PV) inputs and outputs, and changes to the Ground Heat Pump (GHP) and Electric Storage models. It also includes updates to the API endpoints and the project's dependencies. Below is a summary of the most important changes grouped by theme.

Financial Constraints and Outputs:

  • Added new financial inputs: min_initial_capital_costs_before_incentives and max_initial_capital_costs_before_incentives to define bounds for upfront capital costs. [1] [2]
  • Added financial outputs: initial_capital_costs_after_incentives_bau and lifecycle_capital_costs_bau for BAU technologies such as ExistingBoiler and ExistingChiller.

Photovoltaic (PV) Enhancements:

  • Added new PV inputs (size_class, installed_cost_per_kw, om_cost_per_kw) and outputs (installed_cost_per_kw, om_cost_per_kw) to improve PV cost modeling. [1] [2] [3]
  • Introduced a new API endpoint /pv_cost_defaults for retrieving PV cost parameters based on input data. [1] [2]

Ground Heat Pump (GHP) Updates:

  • Added new GHP inputs: load_served_by_ghp, max_number_of_boreholes, and max_ton to provide more detailed control over GHP constraints.

Electric Storage Updates:

  • Introduced new electric storage inputs such as cost_constant_replacement_year, installed_cost_constant, and replace_cost_constant. Updated default values for installed_cost_per_kw and installed_cost_per_kwh. [1] [2] [3]

Dependency and Version Updates:

  • Updated the REopt dependency in Manifest.toml to version 0.52.0 and linked it to the develop branch of the repository.

adfarth and others added 30 commits March 20, 2025 09:44
@Bill-Becker Bill-Becker marked this pull request as ready for review June 4, 2025 21:06
@Bill-Becker Bill-Becker changed the title PV Size Classes for Cost PV Size Classes and Battery Defaults for Costs based on ATB 2024 Jun 13, 2025
@Bill-Becker Bill-Becker changed the title PV Size Classes and Battery Defaults for Costs based on ATB 2024 PV and Battery Cost Update, GHP Inputs Jun 13, 2025
@Bill-Becker Bill-Becker changed the title PV and Battery Cost Update, GHP Inputs PV and Battery Cost Update, GHP Inputs, CapEx Constraints Jun 13, 2025
@Bill-Becker Bill-Becker requested a review from Copilot June 13, 2025 21:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces several new cost-related financial constraints along with enhancements to the PV, GHP, and Electric Storage models. Key changes include the addition of new financial inputs/outputs, updates to PV and battery cost parameters, and new API endpoints (e.g., pv_cost_defaults).

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
reoptjl/test/posts/all_inputs_test.json Added new test keys for financial and battery cost inputs
reoptjl/src/process_results.py Added handling for new PV inputs update in the database update routine
reoptjl/models.py Introduced new model fields for financial constraints, PV enhancements, storage updates, and GHP configurations
julia_src/http.jl Added a new endpoint (pv_cost_defaults) and updated keyword argument handling for PV cost defaults extraction
Various migration files Added migrations to support the new model fields and updated dependencies
julia_src/Manifest.toml & CHANGELOG.md Updated dependency versions and documented the feature changes
Comments suppressed due to low confidence (2)

julia_src/http.jl:619

  • [nitpick] Add inline comments explaining the use of keyword arguments expansion in this call to improve clarity and maintainability.
data["installed_cost_per_kw"], data["om_cost_per_kw"], data["size_class"], tech_sizes_for_cost_curve, data["size_kw_for_size_class"] = reoptjl.get_pv_cost_params(; (Symbol(k) => v for (k, v) in pairs(d))... )

reoptjl/test/posts/all_inputs_test.json:30

  • [nitpick] Ensure that test assertions are updated to account for the newly added financial and battery cost input fields.
"min_initial_capital_costs_before_incentives": null,

@Bill-Becker Bill-Becker merged commit bddd088 into develop Jun 16, 2025
@Bill-Becker Bill-Becker deleted the pv-cost branch June 16, 2025 20:20
@Bill-Becker Bill-Becker mentioned this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants