-
Notifications
You must be signed in to change notification settings - Fork 64
PV and Battery Cost Update, GHP Inputs, CapEx Constraints #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces several new cost-related financial constraints along with enhancements to the PV, GHP, and Electric Storage models. Key changes include the addition of new financial inputs/outputs, updates to PV and battery cost parameters, and new API endpoints (e.g., pv_cost_defaults).
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| reoptjl/test/posts/all_inputs_test.json | Added new test keys for financial and battery cost inputs |
| reoptjl/src/process_results.py | Added handling for new PV inputs update in the database update routine |
| reoptjl/models.py | Introduced new model fields for financial constraints, PV enhancements, storage updates, and GHP configurations |
| julia_src/http.jl | Added a new endpoint (pv_cost_defaults) and updated keyword argument handling for PV cost defaults extraction |
| Various migration files | Added migrations to support the new model fields and updated dependencies |
| julia_src/Manifest.toml & CHANGELOG.md | Updated dependency versions and documented the feature changes |
Comments suppressed due to low confidence (2)
julia_src/http.jl:619
- [nitpick] Add inline comments explaining the use of keyword arguments expansion in this call to improve clarity and maintainability.
data["installed_cost_per_kw"], data["om_cost_per_kw"], data["size_class"], tech_sizes_for_cost_curve, data["size_kw_for_size_class"] = reoptjl.get_pv_cost_params(; (Symbol(k) => v for (k, v) in pairs(d))... )
reoptjl/test/posts/all_inputs_test.json:30
- [nitpick] Ensure that test assertions are updated to account for the newly added financial and battery cost input fields.
"min_initial_capital_costs_before_incentives": null,
REopt.jl develop PR with list of feature branch PRs:
This pull request introduces several updates across multiple areas, including new financial constraints, enhancements to photovoltaic (PV) inputs and outputs, and changes to the Ground Heat Pump (GHP) and Electric Storage models. It also includes updates to the API endpoints and the project's dependencies. Below is a summary of the most important changes grouped by theme.
Financial Constraints and Outputs:
min_initial_capital_costs_before_incentivesandmax_initial_capital_costs_before_incentivesto define bounds for upfront capital costs. [1] [2]initial_capital_costs_after_incentives_bauandlifecycle_capital_costs_baufor BAU technologies such as ExistingBoiler and ExistingChiller.Photovoltaic (PV) Enhancements:
size_class,installed_cost_per_kw,om_cost_per_kw) and outputs (installed_cost_per_kw,om_cost_per_kw) to improve PV cost modeling. [1] [2] [3]/pv_cost_defaultsfor retrieving PV cost parameters based on input data. [1] [2]Ground Heat Pump (GHP) Updates:
load_served_by_ghp,max_number_of_boreholes, andmax_tonto provide more detailed control over GHP constraints.Electric Storage Updates:
cost_constant_replacement_year,installed_cost_constant, andreplace_cost_constant. Updated default values forinstalled_cost_per_kwandinstalled_cost_per_kwh. [1] [2] [3]Dependency and Version Updates:
REoptdependency inManifest.tomlto version0.52.0and linked it to thedevelopbranch of the repository.