Merged
Conversation
fadi-george
approved these changes
Dec 12, 2025
- Removes unused hashUsingSha1() and hashUsingMD5() methods and associated CommonCrypto declarations. These were legacy methods that are no longer used. - Fixes #1546
fadi-george
approved these changes
Dec 15, 2025
abdulraqeeb33
approved these changes
Dec 15, 2025
Base automatically changed from
fix/forward_declaration_objective-cpp_compatibility
to
main
December 16, 2025 21:57
Merged
This was referenced Jan 9, 2026
This was referenced Jan 26, 2026
This was referenced Jan 27, 2026
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Remove
OSMacros.hfrom public exportOneSignalCore.h.Details
Motivation
Removed
OSMacros.hfrom public exportOneSignalCore.hOneSignalFramework.hin bridging header results in errorNo type or protocol named 'OSUser'/'OSLiveActivities'#1512Testing
Unit testing
None
Manual testing
Run example app on emulator 18.5
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is