Skip to content

fix: use locale-independent formatting for purchase prices #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nan-li merged 2 commits into from
Jan 26, 2026
Merged

fix: use locale-independent formatting for purchase prices #1634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f07edcb
fix: use locale-independent formatting for purchase prices
nan-li Jan 17, 2026
a2862fb
chore: update xcode ci for failing build
nan-li Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
steps:
- name: Select Xcode Version
run: |
sudo xcode-select -s /Applications/Xcode_16.3.0.app
sudo xcode-select -s /Applications/Xcode_16.4.0.app
- name: Checkout OneSignal-iOS-SDK
uses: actions/checkout@v3
- name: Set Default Scheme
Expand Down
1 change: 1 addition & 0 deletions iOS_SDK/OneSignalSDK/Source/OneSignalTrackIAP.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ - (void)productsRequest:(id)request didReceiveResponse:(id)response {

// SKProduct.price is an NSDecimalNumber, but the backend expects a String
NSNumberFormatter *formatter = [NSNumberFormatter new];
[formatter setLocale:[NSLocale localeWithLocaleIdentifier:@"en_US_POSIX"]];
[formatter setMinimumFractionDigits:2];
NSString *formattedPrice = [formatter stringFromNumber:[skProduct performSelector:@selector(price)]];

Expand Down
Loading