Skip to content

Conversation

@gaborpapp
Copy link
Contributor

closes #112

@floe
Copy link
Contributor

floe commented Feb 11, 2015

Looks good for me, but since it's changing some internals, maybe @christiankerl can weigh in?

@christiankerl
Copy link
Contributor

Well. My suggestion would be to create a separate binary. E.g. dumprawir implement a simple depthpacketprocessor subclass which just dumps the data. Finally create a custom packet pipeline based on basepacketpipeline you only need to implement one method. This can be done in a single CPP file. I would really appreciate if you make the effort and implement it this way instead of adapting the cpudepthpacketprocessor. Thanks!

@gaborpapp
Copy link
Contributor Author

We discussed how we address this in #112, but your suggestion seems cleaner. I'll try to do it in this way then.

@christiankerl
Copy link
Contributor

Sorry for not commenting earlier, but I'm little busy lately

@gaborpapp
Copy link
Contributor Author

another try in #169, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_opengl crashes while loading ptable's

3 participants