Skip to content

use char override for string.Join #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bording merged 1 commit into from
Mar 20, 2025
Merged

use char override for string.Join #4896

bording merged 1 commit into from
Mar 20, 2025

Conversation

@SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Mar 20, 2025

avoids putting a string on the heap

@bording bording changed the base branch from master to improvements March 20, 2025 21:58
@bording bording merged commit 551e2f6 into Particular:improvements Mar 20, 2025
3 of 27 checks passed
@bording bording mentioned this pull request Mar 20, 2025
Merged
@bording
Copy link
Member

bording commented Mar 20, 2025

Merging into master via #4902

bording added a commit that referenced this pull request Mar 20, 2025
@bording @SimonCropp
Improvements (#4902)
c19f6bd 
* avoid array allocations for string split (#4895)

* use char override for string.Join (#4896)

* use concat instead of join (#4897)

* Undo changes to RavenDB indexes

---------

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramonsmits ramonsmits ramonsmits approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonCropp @bording @ramonsmits