use char override for string.Join

src/Particular.LicensingComponent.UnitTests/API/APIApprovals.cs

@@ -39,7 +39,7 @@ public void HttpApiRoutes()
                     return new
                     {
                         MethodSignature = methodSignature,
-                        HttpMethods = string.Join("/", httpMethods),
+                        HttpMethods = string.Join('/', httpMethods),
                         Route = route.Template
                     };
                 })

src/ServiceControl.AcceptanceTests/TestSupport/SelfVerification/EndpointNameEnforcementTests.cs

@@ -21,7 +21,7 @@ public void EndpointName_should_not_exceed_maximum_length()
                 .Where(t => Conventions.EndpointNamingConvention(t).Length > endpointNameMaxLength)
                 .ToList();
 
-            Assert.That(violators, Is.Empty, string.Join(",", violators));
+            Assert.That(violators, Is.Empty, string.Join(',', violators));
         }
 
         static bool IsEndpointClass(Type t) => endpointConfigurationBuilderType.IsAssignableFrom(t);

src/ServiceControl.Audit.AcceptanceTests/TestSupport/SelfVerification/EndpointNameEnforcementTests.cs

@@ -21,7 +21,7 @@ public void EndpointName_should_not_exceed_maximum_length()
                 .Where(t => Conventions.EndpointNamingConvention(t).Length > endpointNameMaxLength)
                 .ToList();
 
-            Assert.That(violators, Is.Empty, string.Join(",", violators));
+            Assert.That(violators, Is.Empty, string.Join(',', violators));
         }
 
         static bool IsEndpointClass(Type t) => endpointConfigurationBuilderType.IsAssignableFrom(t);

src/ServiceControl.Audit.Persistence.RavenDB/Indexes/MessagesViewIndex.cs

@@ -26,7 +26,7 @@ from message in messages
                     DeliveryTime = (TimeSpan?)message.MessageMetadata["DeliveryTime"],
                     Query = message.MessageMetadata.Select(_ => _.Value.ToString()).Union(new[]
                     {
-                                      string.Join(" ", message.Headers.Select(x => x.Value))
+                                      string.Join(' ', message.Headers.Select(x => x.Value))
                                   }).ToArray(),
                     ConversationId = (string)message.MessageMetadata["ConversationId"]
                 };

src/ServiceControl.Audit.Persistence.RavenDB/Indexes/MessagesViewIndexWithFullTextSearch.cs

@@ -26,7 +26,7 @@ from message in messages
                     DeliveryTime = (TimeSpan?)message.MessageMetadata["DeliveryTime"],
                     Query = message.MessageMetadata.Select(_ => _.Value.ToString()).Union(new[]
                     {
-                                    string.Join(" ", message.Headers.Select(x => x.Value)),
+                                    string.Join(' ', message.Headers.Select(x => x.Value)),
                                     LoadAttachment(message, "body").GetContentAsString()
                                 }).ToArray(),
                     ConversationId = (string)message.MessageMetadata["ConversationId"]

src/ServiceControl.Audit.UnitTests/API/APIApprovals.cs

@@ -64,7 +64,7 @@ public void HttpApiRoutes()
                     return new
                     {
                         MethodSignature = methodSignature,
-                        HttpMethods = string.Join("/", httpMethods),
+                        HttpMethods = string.Join('/', httpMethods),
                         Route = route.Template
                     };
                 })

src/ServiceControl.Audit/Infrastructure/FullTypeNameOnlyBehavior.cs

@@ -16,7 +16,7 @@ public Task Invoke(IOutgoingPhysicalMessageContext context, Func<IOutgoingPhysic
                 enclosedTypes[i] = enclosedTypes[i].Replace($", {AssemblyFullName}", string.Empty);
             }
 
-            context.Headers[Headers.EnclosedMessageTypes] = string.Join(";", enclosedTypes);
+            context.Headers[Headers.EnclosedMessageTypes] = string.Join(';', enclosedTypes);
 
             return next(context);
         }

src/ServiceControl.Config/Validation/Validations.cs

@@ -177,7 +177,7 @@ public static IRuleBuilderOptions<T, string> MonitoringInstancePortAvailable<T>(
         public static IRuleBuilderOptions<T, string> ValidPath<T>(this IRuleBuilder<T, string> rulebuilder)
         {
             return rulebuilder.Must((t, path) => { return path != null && !path.Intersect(ILLEGAL_PATH_CHARS).Any(); })
-                .WithMessage(string.Format(MSG_ILLEGAL_PATH_CHAR, string.Join(" ", ILLEGAL_PATH_CHARS)));
+                .WithMessage(string.Format(MSG_ILLEGAL_PATH_CHAR, string.Join(' ', ILLEGAL_PATH_CHARS)));
         }
 
         public static IRuleBuilderOptions<T, TProperty> MustNotBeIn<T, TProperty>(this IRuleBuilder<T, TProperty> ruleBuilder, Func<T, IEnumerable<TProperty>> list) where TProperty : class

src/ServiceControl.Monitoring.AcceptanceTests/ConventionEnforcementTests.cs

@@ -20,7 +20,7 @@ public void Ensure_all_tests_derive_from_a_common_base_class()
                 .Where(t => t.BaseType == null || !typeof(NServiceBusAcceptanceTest).IsAssignableFrom(t))
                 .ToList();
 
-            Assert.That(missingBaseClass, Is.Empty, string.Join(",", missingBaseClass));
+            Assert.That(missingBaseClass, Is.Empty, string.Join(',', missingBaseClass));
         }
 
         [Test]
@@ -33,7 +33,7 @@ public void Ensure_all_sagadatas_are_public()
                 .Where(t => typeof(IContainSagaData).IsAssignableFrom(t))
                 .ToList();
 
-            Assert.That(sagaDatas, Is.Empty, string.Join(",", sagaDatas));
+            Assert.That(sagaDatas, Is.Empty, string.Join(',', sagaDatas));
         }
 
         static bool HasTestMethod(Type t)

src/ServiceControl.Monitoring.AcceptanceTests/TestSupport/SelfVerification/EndpointNameEnforcementTests.cs

@@ -21,7 +21,7 @@ public void EndpointName_should_not_exceed_maximum_length()
                 .Where(t => Conventions.EndpointNamingConvention(t).Length > endpointNameMaxLength)
                 .ToList();
 
-            Assert.That(violators, Is.Empty, string.Join(",", violators));
+            Assert.That(violators, Is.Empty, string.Join(',', violators));
         }
 
         static bool IsEndpointClass(Type t) => endpointConfigurationBuilderType.IsAssignableFrom(t);

src/ServiceControl.Monitoring.UnitTests/API/APIApprovals.cs

@@ -41,7 +41,7 @@ public void HttpApiRoutes()
                 return new
                 {
                     MethodSignature = methodSignature,
-                    HttpMethods = string.Join("/", httpMethods),
+                    HttpMethods = string.Join('/', httpMethods),
                     Route = route.Template
                 };
             })

src/ServiceControl.MultiInstance.AcceptanceTests/TestSupport/SelfVerification/EndpointNameEnforcementTests.cs

@@ -21,7 +21,7 @@ public void EndpointName_should_not_exceed_maximum_length()
                 .Where(t => Conventions.EndpointNamingConvention(t).Length > endpointNameMaxLength)
                 .ToList();
 
-            Assert.That(violators, Is.Empty, string.Join(",", violators));
+            Assert.That(violators, Is.Empty, string.Join(',', violators));
         }
 
         static bool IsEndpointClass(Type t) => endpointConfigurationBuilderType.IsAssignableFrom(t);

src/ServiceControl.Persistence.RavenDB/Indexes/MessagesViewIndex.cs

@@ -32,7 +32,7 @@ from message in messages
                     CriticalTime = (TimeSpan?)last.MessageMetadata["CriticalTime"],
                     ProcessingTime = (TimeSpan?)last.MessageMetadata["ProcessingTime"],
                     DeliveryTime = (TimeSpan?)last.MessageMetadata["DeliveryTime"],
-                    Query = last.MessageMetadata.Select(_ => _.Value.ToString()).Union(new[] { string.Join(" ", last.Headers.Select(x => x.Value)) }).ToArray(),
+                    Query = last.MessageMetadata.Select(_ => _.Value.ToString()).Union(new[] { string.Join(' ', last.Headers.Select(x => x.Value)) }).ToArray(),
                     ConversationId = (string)last.MessageMetadata["ConversationId"]
                 };
 

src/ServiceControl.Persistence/RetryHistory.cs

@@ -38,7 +38,7 @@ public void AddToHistory(HistoricRetryOperation historicOperation, int historyDe
 
         public string GetHistoryOperationsUniqueIdentifier()
         {
-            return string.Join(",", HistoricOperations.Select(x => x.RequestId));
+            return string.Join(',', HistoricOperations.Select(x => x.RequestId));
         }
 
         public void AddToUnacknowledged(UnacknowledgedRetryOperation unacknowledgedRetryOperation)

src/ServiceControl.Transports.ASQ/ConnectionStringExtensions.cs

@@ -24,11 +24,9 @@ public static string RemoveCustomConnectionStringParts(this string connectionStr
                         break;
                 }
             }
-            return string.Join(";", parts);
+            return string.Join(';', parts);
         }
 
-
-
         const string SubscriptionsTableName = "Subscriptions Table";
 
         static readonly Regex ConnectionStringRegex =

src/ServiceControl.UnitTests/API/APIApprovals.cs

@@ -74,7 +74,7 @@ public void HttpApiRoutes()
                     return new
                     {
                         MethodSignature = methodSignature,
-                        HttpMethods = string.Join("/", httpMethods),
+                        HttpMethods = string.Join('/', httpMethods),
                         Route = route.Template
                     };
                 })

src/ServiceControl/ExternalIntegrations/RemoveVersionInformationBehavior.cs

@@ -13,7 +13,7 @@ public override Task Invoke(IOutgoingPhysicalMessageContext context, Func<Task>
             {
                 var types = typeHeader.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries);
 
-                var typesWithoutVersionInfo = string.Join(";", types.Select(x => RemoveVersionAndKeyInformation(x)));
+                var typesWithoutVersionInfo = string.Join(';', types.Select(x => RemoveVersionAndKeyInformation(x)));
 
                 context.Headers[NServiceBus.Headers.EnclosedMessageTypes] = typesWithoutVersionInfo;
             }

src/ServiceControlInstaller.Packaging.UnitTests/AuditDeploymentPackageTests.cs

@@ -22,7 +22,7 @@ public void Should_package_storages_individually()
 
             var persisters = deploymentPackage.DeploymentUnits.Where(u => u.Category == "Persisters");
 
-            Assert.That(persisters.Select(d => d.Name), Is.EquivalentTo(expectedPersisters), $"Expected Persisters folder to contain {string.Join(",", expectedPersisters)}");
+            Assert.That(persisters.Select(d => d.Name), Is.EquivalentTo(expectedPersisters), $"Expected Persisters folder to contain {string.Join(',', expectedPersisters)}");
 
             foreach (var persister in persisters)
             {

src/ServiceControlInstaller.Packaging.UnitTests/DeploymentPackageTests.cs

@@ -94,7 +94,7 @@ public void Should_package_all_transports()
                 .Where(u => u.Category == "Transports")
                 .Select(u => u.Name);
 
-            Assert.That(bundledTransports, Is.EquivalentTo(allTransports), $"Expected transports folder to contain {string.Join(",", allTransports)}");
+            Assert.That(bundledTransports, Is.EquivalentTo(allTransports), $"Expected transports folder to contain {string.Join(',', allTransports)}");
         }
 
         readonly DeploymentPackage deploymentPackage;

src/ServiceControlInstaller.Packaging.UnitTests/PrimaryDeploymentPackageTests.cs

@@ -21,7 +21,7 @@ public void Should_package_storages_individually()
 
             var persisters = deploymentPackage.DeploymentUnits.Where(u => u.Category == "Persisters");
 
-            Assert.That(persisters.Select(d => d.Name), Is.EquivalentTo(expectedPersisters), $"Expected Persisters folder to contain {string.Join(",", expectedPersisters)}");
+            Assert.That(persisters.Select(d => d.Name), Is.EquivalentTo(expectedPersisters), $"Expected Persisters folder to contain {string.Join(',', expectedPersisters)}");
 
             foreach (var persister in persisters)
             {