Skip to content

Only require endpoint name to be available when detecting receiving endpoint details #4945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andreasohlund wants to merge 2 commits into from
Closed

Only require endpoint name to be available when detecting receiving endpoint details #4945

andreasohlund wants to merge 2 commits into from

Conversation

@andreasohlund
Copy link
Member

@andreasohlund andreasohlund commented Apr 24, 2025 •
edited
Loading

This lowers the bar further when it comes to importing failures into service control.

@andreasohlund andreasohlund self-assigned this Apr 24, 2025
@andreasohlund
# This is a combination of 3 commits.
c0e73ee 
# This is the 1st commit message:

Only require endpoint name to be present to consider an endpoint detected

# This is the commit message #2:

Isolate changes

# This is the commit message #3:

More rollbacks

Only require endpoint name to be available when detecting receiving endpoint details

Fix merge
@andreasohlund andreasohlund added this to the vNext milestone Apr 25, 2025
@andreasohlund andreasohlund marked this pull request as ready for review April 25, 2025 08:58
@andreasohlund andreasohlund mentioned this pull request Apr 28, 2025
Closed
@andreasohlund andreasohlund marked this pull request as draft April 29, 2025 06:54
@andreasohlund andreasohlund mentioned this pull request Apr 29, 2025
Open
@andreasohlund
Copy link
Member Author

andreasohlund commented Apr 29, 2025 •
edited by ramonsmits
Loading

Talking to @johnsimons I realized that even though the change is trivial more testing should be done and changes to the API considered.

Raised the following to track this:

@andreasohlund andreasohlund deleted the do-not-require-host branch April 29, 2025 07:10
@PhilBastian PhilBastian removed this from the 6.7.0 milestone Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramonsmits ramonsmits Awaiting requested review from ramonsmits

Assignees

@andreasohlund andreasohlund

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreasohlund @PhilBastian