Convert ServiceControl loggers to Microsoft.Extensions.Logging #5000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilBastian
commented
Jun 9, 2025
…xtensions.logging_spike
…xtensions.logging_spike
…ontrol.infrastructure
ramonsmits
reviewed
Jun 24, 2025
Member
ramonsmits
left a comment
ramonsmits
left a comment
There was a problem hiding this comment.
Great job!
Some questions:
- Why not OpenTelemetry OLTP exporter? I think this is even supported by Seq.
- Ensure all loggers/providers are always flushed in finally
- I think a bootstrap logger that is based on logging extensions would make sense.
- As a lot of init is done only in "commands" where a hostbuilder is created any logger lifetimes there could be ended when that host instance gets disposed. If Seq/NLog its initialized and passed this can't result in lifetime issues
- Seems that some log statements can benefit from logger scopes like OnMessagein the ingestioners, custom checks, etc. but maybe that that should not be part of this PR as its already HUGE
- Do a search on
."as I saw many messages ending in.
src/ServiceControl.Audit.Persistence.RavenDB/CustomChecks/CheckDirtyMemory.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Audit.Persistence.RavenDB/CustomChecks/CheckDirtyMemory.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl.Audit.Persistence.RavenDB/CustomChecks/CheckDirtyMemory.cs
Show resolved
Hide resolved
src/ServiceControl.Audit.Persistence.RavenDB/CustomChecks/CheckFreeDiskSpace.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl/Monitoring/HeartbeatEndpointSettingsSyncHostedService.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl/Monitoring/HeartbeatEndpointSettingsSyncHostedService.cs
Outdated
Show resolved
Hide resolved
src/ServiceControl/Recoverability/Retrying/Infrastructure/ReturnToSender.cs
Show resolved
Hide resolved
…tedService.cs Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
…tedService.cs Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
…xtensions.logging_spike
Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
…resource management during shutdown.
jasontaylordev
approved these changes
Jul 2, 2025
This was referenced Jul 2, 2025
PhilBastian
changed the title
DavidBoike
changed the title
jasontaylordev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.