Add county FIPS dataset #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@nikhilwoodruff Would love your review and expertise on this, as I am new to this package and this type of programming. In particular, is the code I wrote to convert the government's dataset into the format we're looking for correct? |
This was referenced Mar 21, 2025
Contributor
|
Will review by EOD tomorrow |
nikhilwoodruff
approved these changes
Mar 25, 2025
nikhilwoodruff
approved these changes
Mar 27, 2025
Contributor
nikhilwoodruff
left a comment
nikhilwoodruff
left a comment
There was a problem hiding this comment.
If we're doing this every few years, seems totally fine to have it be a one-off script we run. LGTM
This was referenced Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #194
Fixes #198
This PR adds the code to create a generate a small county FIPS dataset from a 2020 US Census Bureau source. It also adds the generated dataset, code to export the dataset, and tests to ensure the dataset follows an expected structure.
@nikhilwoodruff Does this structure (a one-off script to create the dataset that is not regularly accessed via some sort of GH Actions script) work for this dataset?