Skip to content

Conversation

@yans6666
Copy link
Contributor

@yans6666 yans6666 commented May 27, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/Infineon/psoc6-evaluationkit-062S2
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented May 27, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added BSP BSP: Infineon BSP related with Infineon labels May 27, 2025
@kurisaW
Copy link
Member

kurisaW commented May 28, 2025

需考虑一下rt_device级别的API实现是不是支持这样的写法

@yans6666 yans6666 marked this pull request as draft May 28, 2025 01:35
return -RT_ENOSYS;
}

/* Initialize a channel 0 and configure it to scan P10_0 in single ended mode. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这么改了后,注释记得也修改下吧

@yans6666 yans6666 marked this pull request as ready for review May 28, 2025 08:35
@kurisaW
Copy link
Member

kurisaW commented May 28, 2025

lgtm

char *name;
};

const cyhal_gpio_t adc_gpio[8] = {P14_0, P14_1, P14_2, P14_3, P14_4, P14_5, P14_6, P14_7};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个IO在psoc6平台上都是通用的吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOC_CY8C624ALQI_S2D42, SOC_CY8C6347BZI_BLD53, SOC_CY8C6247BZI_D54, SOC_CY8C6244LQI_S4D92这几个芯片的ADC引脚是一样的

@@ -0,0 +1,62 @@
/*
* Copyright (c) 2006-2021, RT-Thread Development Team
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

日期需要都修改下

@yans6666 yans6666 force-pushed the fix_psoc62_adc branch 2 times, most recently from 8175fbd to 5e7ee6b Compare May 29, 2025 03:01
@Rbb666 Rbb666 merged commit dcf637d into RT-Thread:master May 29, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Infineon BSP related with Infineon BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants