Skip to content

Conversation

@rammodhvadia
Copy link
Contributor

@rammodhvadia rammodhvadia commented Feb 12, 2026

Adds 2 vars for styling buttons - used in projects-ui

--project-bar-button-radius - used to set radius for buttons in the project bar component
--rpf-primary-button-radius - used to set radius for the primary buttons from the Button.jsx component

Example in projects-ui

Before
image
image

After
image
image

@rammodhvadia rammodhvadia temporarily deployed to previews/1322/merge February 12, 2026 08:51 — with GitHub Actions Inactive
@rammodhvadia rammodhvadia temporarily deployed to previews/1322/merge February 12, 2026 10:25 — with GitHub Actions Inactive
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces new CSS custom properties to make button corner rounding configurable in the Projects UI, enabling a “rounded buttons” refresh while preserving existing styling via fallbacks.

Changes:

  • Add --project-bar-button-radius support for buttons within the project bar styling.
  • Add --rpf-primary-button-radius support for primary buttons in Button.scss.
  • Minor formatting cleanup in ProjectBar.scss and reformatting of two var(...) declarations in Button.scss.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/assets/stylesheets/ProjectBar.scss Applies a configurable border-radius to project-bar buttons via --project-bar-button-radius.
src/assets/stylesheets/Button.scss Applies a configurable border-radius to primary buttons via --rpf-primary-button-radius; also reformats two var(...) declarations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +19 to +27
.btn {
border-radius: var(--project-bar-button-radius, $space-0-5);
&:hover,
&:active,
&:focus-visible,
&::before {
border-radius: var(--project-bar-button-radius, $space-0-5);
}
}
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new .project-bar .btn rule is more specific than the existing .project-bar__btn rule later in this file, so it will override any border-radius set on .project-bar__btn. To avoid confusing/unused styling, consider scoping this new radius override to .project-bar__btn instead of .btn, or update/remove the redundant border-radius in .project-bar__btn so there’s only one source of truth for button rounding in the project bar.

Copilot uses AI. Check for mistakes.
Comment on lines 36 to 60
@@ -56,7 +56,7 @@
&:hover,
.btn-outer:hover & {
background-color: var(--rpf-button-primary-background-color-hover);
border-radius: $space-0-5;
border-radius: var(--rpf-primary-button-radius, $space-0-5);
}
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--rpf-primary-button-radius is introduced here, but the project appears to centralize button CSS custom properties in src/assets/stylesheets/index.scss under the .btn, .rpf-button { ... } blocks (e.g., --rpf-button-primary-background-color, etc.). Consider adding a default --rpf-primary-button-radius there as well so the new theming hook is discoverable and consistent with how other button variables are configured (even if this file still keeps the fallback).

Copilot uses AI. Check for mistakes.
Comment on lines 239 to 249
&:hover {
background-color: var(--rpf-button-tertiary-danger-background-color-hover);
background-color: var(
--rpf-button-tertiary-danger-background-color-hover
);
}

&:active {
background-color: var(--rpf-button-tertiary-danger-background-color-active);
background-color: var(
--rpf-button-tertiary-danger-background-color-active
);
}
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to multi-line var(...) formatting in these declarations is inconsistent with the rest of Button.scss, where var(--...) is kept on a single line. Unless there’s a lint/line-length requirement driving this, consider reverting to the single-line form to avoid unnecessary diff churn and keep styling consistent.

Copilot uses AI. Check for mistakes.
@rammodhvadia rammodhvadia merged commit 9f60693 into main Feb 12, 2026
13 checks passed
@rammodhvadia rammodhvadia deleted the rounded-buttons-projects-site-refresh branch February 12, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants