Skip to content

Rounded buttons projects site refresh #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rammodhvadia merged 4 commits into from
Feb 12, 2026
Merged

Rounded buttons projects site refresh #1322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa0c61f
add class to run button for button radius
rammodhvadia Feb 12, 2026
482de17
custom border radius for project bar buttons
rammodhvadia Feb 12, 2026
8fcfe92
undo changes to runner controls
rammodhvadia Feb 12, 2026
0860569
add border radius var for primary button
rammodhvadia Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/assets/stylesheets/Button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

&--primary {
background-color: var(--rpf-button-primary-background-color);
border-radius: $space-0-5;
border-radius: var(--rpf-primary-button-radius, $space-0-5);

color: var(--rpf-button-primary-text-color);

Expand All @@ -56,7 +56,7 @@
&:hover,
.btn-outer:hover & {
background-color: var(--rpf-button-primary-background-color-hover);
border-radius: $space-0-5;
border-radius: var(--rpf-primary-button-radius, $space-0-5);
}

&:disabled {
Expand Down Expand Up @@ -237,11 +237,15 @@
}

&:hover {
background-color: var(--rpf-button-tertiary-danger-background-color-hover);
background-color: var(
--rpf-button-tertiary-danger-background-color-hover
);
}

&:active {
background-color: var(--rpf-button-tertiary-danger-background-color-active);
background-color: var(
--rpf-button-tertiary-danger-background-color-active
);
}
Comment on lines 239 to 249
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to multi-line var(...) formatting in these declarations is inconsistent with the rest of Button.scss, where var(--...) is kept on a single line. Unless there’s a lint/line-length requirement driving this, consider reverting to the single-line form to avoid unnecessary diff churn and keep styling consistent.

Copilot uses AI. Check for mistakes.
}
}
Expand Down
29 changes: 19 additions & 10 deletions src/assets/stylesheets/ProjectBar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,24 @@
justify-content: left;
}

.btn {
border-radius: var(--project-bar-button-radius, $space-0-5);
&:hover,
&:active,
&:focus-visible,
&::before {
border-radius: var(--project-bar-button-radius, $space-0-5);
}
}
Comment on lines +19 to +27
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new .project-bar .btn rule is more specific than the existing .project-bar__btn rule later in this file, so it will override any border-radius set on .project-bar__btn. To avoid confusing/unused styling, consider scoping this new radius override to .project-bar__btn instead of .btn, or update/remove the redundant border-radius in .project-bar__btn so there’s only one source of truth for button rounding in the project bar.

Copilot uses AI. Check for mistakes.

.btn--save {
@container (min-width: 560px) {
.icon {
display: none;
}
}
}

.project-name {
border-inline-end: 1px solid var(--editor-color-outline);
margin-inline-end: -1px;
Expand All @@ -28,18 +46,9 @@
}
}

.btn--save {
border-radius: $space-0-5;
@container (min-width: 560px) {
.icon {
display: none;
}
}
}

.project-bar__btn-wrapper {
display: flex;
block-size: 100%;
block-size: 100%;
}

.project-bar__btn-wrapper:not(:last-child) {
Expand Down