-
Notifications
You must be signed in to change notification settings - Fork 1k
Support for nafill of character #7581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7581 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 87 87
Lines 16754 16791 +37
=======================================
+ Hits 16591 16628 +37
Misses 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Generated via commit 1f56859 Download link for the artifact containing the test results: ↓ atime-results.zip
|
ben-schwen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Feel free to merge after cleaning up the minor things.
|
For my own reference, the jj new pup # pup==commit ID shown in 'jj log', I _think_ jj new nafill-character should work too
# <edits>
jj commit -m 'use switch() over nested ternary checks'
# <more edits, more 'jj commit -m'>
jj rebase -r lp -d vs # rebase #7582 onto 1f56859 (by jj ID)
jj bookmark move nafill-character --to vs # re-associate this PR's bookmark to the end of the commit chain (1f56859)
jj bookmark track nafill-character@origin # boilerplate, I'm not sure why it's needed, but given by helpful error
jj git push |

Another part of #3992; mostly copied from #4980.
The pending part about
setnafill()for character still applies; I am pushing this now as a good step forward even without full support.