Skip to content

Conversation

@MichaelChirico
Copy link
Member

Another part of #3992; mostly copied from #4980.

The pending part about setnafill() for character still applies; I am pushing this now as a good step forward even without full support.

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (f3b166b) to head (1f56859).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7581   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          87       87           
  Lines       16754    16791   +37     
=======================================
+ Hits        16591    16628   +37     
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Jan 10, 2026

  • HEAD=nafill-character slower P<0.001 for melt improved in #5054
    Comparison Plot

Generated via commit 1f56859

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 52 seconds
Installing different package versions 22 seconds
Running and plotting the test cases 4 minutes and 4 seconds

Copy link
Member

@ben-schwen ben-schwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Feel free to merge after cleaning up the minor things.

@MichaelChirico
Copy link
Member Author

For my own reference, the jj commands used to add the recent commits after review:

jj new pup # pup==commit ID shown in 'jj log', I _think_ jj new nafill-character should work too
# <edits>
jj commit -m 'use switch() over nested ternary checks'
# <more edits, more 'jj commit -m'>
jj rebase -r lp -d vs # rebase #7582 onto 1f56859 (by jj ID) 

jj bookmark move nafill-character --to vs # re-associate this PR's bookmark to the end of the commit chain (1f56859)
jj bookmark track nafill-character@origin # boilerplate, I'm not sure why it's needed, but given by helpful error
jj git push

@MichaelChirico MichaelChirico merged commit 0912a66 into master Jan 10, 2026
12 of 13 checks passed
@MichaelChirico MichaelChirico deleted the nafill-character branch January 10, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants