Skip to content

Conversation

@MichaelChirico
Copy link
Member

More of #3992.

Based against #7581, which this includes, via jj

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (0912a66) to head (7f64a78).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7582   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          87       87           
  Lines       16791    16791           
=======================================
  Hits        16628    16628           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-schwen
Copy link
Member

Should we also test setnafill for Date, IDate and POSIXct?

Base automatically changed from nafill-character to master January 10, 2026 23:54
@MichaelChirico
Copy link
Member Author

Should we also test setnafill for Date, IDate and POSIXct?

Yes, it's good for testing future refactors... I ran out of steam & today it's guaranteed by the inclusion of some factor columns.

@github-actions
Copy link

No obvious timing issues in HEAD=nafill-date
Comparison Plot

Generated via commit 7f64a78

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 5 minutes and 0 seconds
Installing different package versions 10 minutes and 56 seconds
Running and plotting the test cases 4 minutes and 2 seconds

@ben-schwen ben-schwen merged commit e55daa5 into master Jan 11, 2026
12 of 13 checks passed
@ben-schwen
Copy link
Member

TY!

@ben-schwen ben-schwen deleted the nafill-date branch January 11, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants