[PoC] Add presentPaywall web support #1485
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpallares
reviewed
Nov 13, 2025
Member
ajpallares
left a comment
ajpallares
left a comment
There was a problem hiding this comment.
Makes sense! Some small comments
| presentedOfferingContext?: Record<string, unknown>, | ||
| _displayCloseButton?: boolean, | ||
| _fontFamily?: string | null, | ||
| ) => { |
Member
There was a problem hiding this comment.
Do we want to return a Promise<PAYWALL_RESULT> in this method as well?
Contributor
Author
There was a problem hiding this comment.
You're right, we should 👍
Comment on lines
+13
to
+14
| _displayCloseButton?: boolean, | ||
| _fontFamily?: string | null, |
Member
There was a problem hiding this comment.
These two are unused. Is it intentional to avoid breaking the API in the future?
Contributor
Author
There was a problem hiding this comment.
Yeah, this is basically called from the shared code, and these parameters are sent. I mostly prefer to have them so we know they exist, but are unused currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO