-
Notifications
You must be signed in to change notification settings - Fork 108
[PoC] Add presentPaywall web support #1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tonidero
wants to merge
6
commits into
main
Choose a base branch
from
add-present-paywall-web
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d017568
Use new presentPaywall in purchases-js-hybrid-mappings
tonidero 5c08b13
Merge branch 'main' into add-present-paywall-web
tonidero 4b696ad
Merge branch 'main' into add-present-paywall-web
tonidero 1f4b387
Merge branch 'main' into add-present-paywall-web
tonidero 90bd8ab
Merge branch 'main' into add-present-paywall-web
tonidero bd02adf
Merge branch 'main' into add-present-paywall-web
tonidero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import { PurchasesCommon } from "@revenuecat/purchases-js-hybrid-mappings" | ||
| import { PAYWALL_RESULT } from "@revenuecat/purchases-typescript-internal" | ||
|
|
||
| /** | ||
|
|
@@ -6,12 +7,30 @@ import { PAYWALL_RESULT } from "@revenuecat/purchases-typescript-internal" | |
| */ | ||
| export const previewNativeModuleRNPaywalls = { | ||
|
|
||
| presentPaywall: () => { | ||
| return PAYWALL_RESULT.NOT_PRESENTED | ||
| presentPaywall: async ( | ||
| offeringIdentifier?: string, | ||
| presentedOfferingContext?: Record<string, unknown>, | ||
| _displayCloseButton?: boolean, | ||
| _fontFamily?: string | null, | ||
| ): Promise<PAYWALL_RESULT> => { | ||
| return await PurchasesCommon.getInstance().presentPaywall({ | ||
| offeringIdentifier, | ||
| presentedOfferingContext, | ||
| }) as PAYWALL_RESULT; | ||
| }, | ||
|
|
||
| presentPaywallIfNeeded: () => { | ||
| return PAYWALL_RESULT.NOT_PRESENTED | ||
| presentPaywallIfNeeded: async ( | ||
| requiredEntitlementIdentifier: string, | ||
| offeringIdentifier?: string, | ||
| presentedOfferingContext?: Record<string, unknown>, | ||
| _displayCloseButton?: boolean, | ||
| _fontFamily?: string | null, | ||
| ) => { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we want to return a
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're right, we should 👍 |
||
| return await PurchasesCommon.getInstance().presentPaywall({ | ||
| requiredEntitlementIdentifier, | ||
| offeringIdentifier, | ||
| presentedOfferingContext, | ||
| }) as PAYWALL_RESULT; | ||
| }, | ||
|
|
||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two are unused. Is it intentional to avoid breaking the API in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is basically called from the shared code, and these parameters are sent. I mostly prefer to have them so we know they exist, but are unused currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Makes total sense!