Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jan 16, 2026

Fixes bug where users with ChatGPT Pro subscription were getting stuck on the "Choose your provider" screen.

Changes

  • Added openai-codex to the list of providers that don't require API key configuration in checkExistKey()
  • Added comprehensive test coverage for all OAuth-based providers (fake-ai, claude-code, openai-codex, qwen-code, roo)

Context

The openai-codex provider uses OAuth authentication (similar to claude-code), so it doesn't require users to manually provide an API key. Without this fix, the extension would incorrectly require API key configuration, preventing users from progressing past the provider selection screen.

Testing

  • All existing tests pass
  • Added 5 new test cases to verify behavior for all OAuth providers

View task on Roo Code Cloud


Important

Adds openai-codex to providers not requiring API key in checkExistKey() and updates tests for OAuth providers.

  • Behavior:
    • Adds openai-codex to providers that don't require API key in checkExistKey() in checkExistApiConfig.ts.
    • Fixes bug preventing users with ChatGPT Pro from progressing past provider selection.
  • Testing:
    • Adds test cases for openai-codex and other OAuth providers in checkExistApiConfig.spec.ts.
    • Verifies behavior for fake-ai, claude-code, qwen-code, and roo providers.

This description was created by Ellipsis for a30c8df. You can customize this summary. It will automatically update as commits are pushed.

@roomote
Copy link
Contributor Author

roomote bot commented Jan 16, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The fix correctly adds openai-codex to OAuth-based providers that don't require API key configuration. The implementation is consistent with existing patterns for similar providers like claude-code.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 16, 2026
@mrubens mrubens marked this pull request as ready for review January 16, 2026 22:00
@mrubens mrubens requested review from cte and jr as code owners January 16, 2026 22:00
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jan 16, 2026
@roomote
Copy link
Contributor Author

roomote bot commented Jan 16, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The fix correctly adds openai-codex to the list of OAuth-based providers that don't require API key configuration. The change is consistent with existing patterns for similar providers like claude-code, and the provider's OAuth authentication is properly implemented in src/integrations/openai-codex/oauth.ts. Test coverage has been added for all OAuth providers.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jan 16, 2026
@mrubens mrubens merged commit c40c882 into main Jan 16, 2026
26 of 28 checks passed
@mrubens mrubens deleted the fix/add-openai-codex-to-no-api-key-providers branch January 16, 2026 22:13
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jan 16, 2026
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jan 16, 2026
@mrubens mrubens mentioned this pull request Jan 16, 2026
@roomote roomote bot mentioned this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants