Change of load_model parameters addresses #23 #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-salomonsen
reviewed
Feb 4, 2025
c-salomonsen
reviewed
Feb 4, 2025
Contributor
|
Nice! I'll pull this branch and update my dataloader with your new change, then push that to this branch. |
Contributor
|
Also, to pass the |
Contributor
Author
|
What a mess 🤦♀️ @Johanmkr can you maybe also update your model based on this branch before we merge your pull request? |
Contributor
|
@hzavadil98 Good job! I adjusted my model accordingly. We can wait for @Johanmkr to push his modifications before merging the PR. |
Contributor
Author
|
@salomaestro Thanks for the formatting tips 👌 yeah let's wait for him |
Merged
Johanmkr
added a commit
that referenced
this pull request
Feb 4, 2025
Contributor
|
@hzavadil98 @salomaestro Good job, I have updated my model and pushed. |
Contributor
|
I can try to go through the conflicts |
Seilmast
pushed a commit
that referenced
this pull request
Feb 7, 2025
Seilmast
pushed a commit
that referenced
this pull request
Feb 7, 2025
Change of load_model parameters addresses #23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the parameter of load_model function to include the whole shape of the image so that the models were applicable on different datasets. #23 (Also contains my implementation of dataset and model which have not been merged before)