[java/vertx] Mark tests as stripped#10658
Closed
p8 wants to merge 1 commit intoTechEmpower:masterfrom
Closed
Conversation
Vertx precalculates HTTP headers, so these tests should be marked as stripped: https://github.com/TechEmpower/FrameworkBenchmarks/blob/d36a2ede0db5c69d70da421e2f48aea53973c0c5/frameworks/Java/vertx/src/main/java/vertx/App.java#L129-L146
Contributor
|
Ping @vietj |
Contributor
|
vertx-web-kotlin-dsljson do the same #10661 |
Contributor
|
what is all of that about ? can somebody elaborate about this ? |
Contributor
|
which document is defining the semantic of "Realistic" / "Stripped" for the benchmark ? |
Contributor
We need to generate the headers, not hard coded or with constants. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vertx precalculates HTTP headers, so these tests should be marked as stripped:
FrameworkBenchmarks/frameworks/Java/vertx/src/main/java/vertx/App.java
Line 89 in d36a2ed
FrameworkBenchmarks/frameworks/Java/vertx/src/main/java/vertx/App.java
Lines 129 to 146 in d36a2ed