Skip to content

fix(settings): disable auto-fallback in default model selection#1316

Merged
zerob13 merged 2 commits intodevfrom
bugfix/default-model
Feb 15, 2026
Merged

fix(settings): disable auto-fallback in default model selection#1316
zerob13 merged 2 commits intodevfrom
bugfix/default-model

Conversation

@zerob13
Copy link
Collaborator

@zerob13 zerob13 commented Feb 15, 2026

Remove automatic model fallback in DefaultModelSettingsSection to prevent unintended model changes when providers load late. Models now only change on explicit user selection.

Summary by CodeRabbit

  • Refactor
    • Default model selection now relies exclusively on explicit configuration (providerId + modelId) for chat, assistant, and vision; automatic fallbacks to other available models were removed.
    • Simplified selection flow by eliminating multi-step fallback behavior, ensuring selections reflect only the configured settings.

Remove automatic model fallback in DefaultModelSettingsSection to prevent
unintended model changes when providers load late. Models now only change
on explicit user selection.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 15, 2026

📝 Walkthrough

Walkthrough

Removed the pickFirstEnabledModel helper and its usages from DefaultModelSettingsSection.vue. Chat, assistant, and vision model selections now use only selectBySetting results; no fallbacks to first-enabled or stored selections remain.

Changes

Cohort / File(s) Summary
Model Selection Refactor
src/renderer/settings/components/common/DefaultModelSettingsSection.vue
Deleted pickFirstEnabledModel and removed fallback logic. syncModelSelections and other selection flows now assign chat, assistant, and vision selections solely from selectBySetting, with vision filtering still applied where relevant.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

codex

Poem

🐰 A helper hopped off into night,
Selects now follow settings' light.
No fallback burrows, choices are clear,
Models aligned — the path is near. 🥕

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(settings): disable auto-fallback in default model selection' clearly and specifically describes the main change: removing automatic fallback logic in model selection, which aligns with the PR's core objective of preventing unintended model changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into dev

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/default-model

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/renderer/settings/components/common/DefaultModelSettingsSection.vue`:
- Around line 226-230: Prettier formatting failed in
DefaultModelSettingsSection.vue for the lines where chatSelection and
assistantSelection are defined; fix it by running the project formatter (pnpm
run format or prettier --write) to reformat the file so selectBySetting calls
and surrounding whitespace match repository Prettier rules, then re-run CI to
confirm the Prettier violation is resolved before merging.

@zerob13 zerob13 merged commit b918a24 into dev Feb 15, 2026
2 checks passed
zerob13 added a commit that referenced this pull request Feb 16, 2026
* fix(settings): disable auto-fallback in default model selection

Remove automatic model fallback in DefaultModelSettingsSection to prevent
unintended model changes when providers load late. Models now only change
on explicit user selection.

* fix: format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant