Skip to content

fix(settings): disable auto-fallback in default model selection #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zerob13 merged 2 commits into from
Feb 15, 2026
Merged

fix(settings): disable auto-fallback in default model selection #1316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92bd2ee
fix(settings): disable auto-fallback in default model selection
zerob13 Feb 15, 2026
2b5adcd
fix: format
zerob13 Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 15 additions & 34 deletions src/renderer/settings/components/common/DefaultModelSettingsSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,19 +163,6 @@ const selectBySetting = (
return { providerId: setting.providerId, model: matchedModel }
}

const pickFirstEnabledModel = (
predicate?: (model: RENDERER_MODEL_META, providerId: string) => boolean
): SelectedModel | null => {
for (const providerEntry of modelStore.enabledModels) {
for (const model of providerEntry.models) {
if (!predicate || predicate(model, providerEntry.providerId)) {
return { providerId: providerEntry.providerId, model }
}
}
}
return null
}

const persistModelSetting = async (
key: 'assistantModel' | 'defaultModel' | 'defaultVisionModel',
previous: { providerId: string; modelId: string } | undefined,
Expand Down Expand Up @@ -236,29 +223,23 @@ const syncModelSelections = async (): Promise<void> => {
| { providerId: string; modelId: string }
| undefined

const chatSelection =
selectBySetting(defaultModelSetting, (_model, providerId) => providerId !== 'acp') ||
pickFirstEnabledModel((_model, providerId) => providerId !== 'acp')
const chatSelection = selectBySetting(
defaultModelSetting,
(_model, providerId) => providerId !== 'acp'
)

const assistantSelection =
selectBySetting(assistantModelSetting, (_model, providerId) => providerId !== 'acp') ||
chatSelection ||
pickFirstEnabledModel((_model, providerId) => providerId !== 'acp')
const assistantSelection = selectBySetting(
assistantModelSetting,
(_model, providerId) => providerId !== 'acp'
)

const visionSelection =
selectBySetting(
defaultVisionModelSetting,
(model, providerId) =>
providerId !== 'acp' &&
Boolean(model.vision) &&
(model.type === ModelType.Chat || model.type === ModelType.ImageGeneration)
) ||
pickFirstEnabledModel(
(model, providerId) =>
providerId !== 'acp' &&
Boolean(model.vision) &&
(model.type === ModelType.Chat || model.type === ModelType.ImageGeneration)
)
const visionSelection = selectBySetting(
defaultVisionModelSetting,
(model, providerId) =>
providerId !== 'acp' &&
Boolean(model.vision) &&
(model.type === ModelType.Chat || model.type === ModelType.ImageGeneration)
)

selectedChatModel.value = chatSelection
selectedAssistantModel.value = assistantSelection
Expand Down