Skip to content

Comments

chore: disable tracing on integration tests#88

Merged
radu-mocanu merged 1 commit intomainfrom
chore/disable-tracing-on-integration-tests
Feb 16, 2026
Merged

chore: disable tracing on integration tests#88
radu-mocanu merged 1 commit intomainfrom
chore/disable-tracing-on-integration-tests

Conversation

@radu-mocanu
Copy link
Collaborator

  • disable tracing on integration tests

Copilot AI review requested due to automatic review settings February 16, 2026 15:46
@radu-mocanu radu-mocanu requested a review from a team as a code owner February 16, 2026 15:46
@radu-mocanu radu-mocanu merged commit a34482f into main Feb 16, 2026
22 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to disable tracing during the integration-test jobs in the GitHub Actions workflows, likely to reduce noise/cost and avoid trace emission during CI runs.

Changes:

  • Adds UIPATH_TRACING_ENABLED: false to the container environment for UiPath integration test jobs.
  • Adds the same environment variable to the container environment for UiPath Langchain integration test jobs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/test-uipath.yml Sets UIPATH_TRACING_ENABLED=false for the integration-test container job.
.github/workflows/test-uipath-langchain.yml Sets UIPATH_TRACING_ENABLED=false for the integration-test container job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 89 to +91
env:
UIPATH_JOB_KEY: "3a03d5cb-fa21-4021-894d-a8e2eda0afe0"
UIPATH_TRACING_ENABLED: false
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UIPATH_TRACING_ENABLED is set here, but in this repo it appears to be parsed and then never applied (see UiPathRuntimeContext.with_defaults in src/uipath/runtime/context.py, where tracing_enabled is computed but not assigned to the context or used to conditionally create/disable a trace manager). Unless another component reads this env var directly, this workflow change likely won’t actually disable tracing for the integration tests. Consider wiring the env var into trace manager initialization (or removing tracing setup when disabled) and/or updating the workflow to use the env var that the tracing implementation actually honors.

Copilot uses AI. Check for mistakes.
Comment on lines 89 to +91
env:
UIPATH_JOB_KEY: "3a03d5cb-fa21-4021-894d-a8e2eda0afe0"
UIPATH_TRACING_ENABLED: false
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UIPATH_TRACING_ENABLED is set here, but in this repo it appears to be parsed and then never applied (see UiPathRuntimeContext.with_defaults in src/uipath/runtime/context.py, where tracing_enabled is computed but not assigned to the context or used to conditionally create/disable a trace manager). Unless another component reads this env var directly, this workflow change likely won’t actually disable tracing for the integration tests. Consider wiring the env var into trace manager initialization (or removing tracing setup when disabled) and/or updating the workflow to use the env var that the tracing implementation actually honors.

Copilot uses AI. Check for mistakes.
@cristipufu cristipufu deleted the chore/disable-tracing-on-integration-tests branch February 16, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants