Skip to content

chore: disable tracing on integration tests #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radu-mocanu merged 1 commit into from
Feb 16, 2026
Merged

chore: disable tracing on integration tests #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test-uipath-langchain.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ jobs:
image: ghcr.io/astral-sh/uv:python3.12-bookworm
env:
UIPATH_JOB_KEY: "3a03d5cb-fa21-4021-894d-a8e2eda0afe0"
UIPATH_TRACING_ENABLED: false
Comment on lines 89 to +91
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UIPATH_TRACING_ENABLED is set here, but in this repo it appears to be parsed and then never applied (see UiPathRuntimeContext.with_defaults in src/uipath/runtime/context.py, where tracing_enabled is computed but not assigned to the context or used to conditionally create/disable a trace manager). Unless another component reads this env var directly, this workflow change likely won’t actually disable tracing for the integration tests. Consider wiring the env var into trace manager initialization (or removing tracing setup when disabled) and/or updating the workflow to use the env var that the tracing implementation actually honors.

Copilot uses AI. Check for mistakes.
permissions:
contents: read
strategy:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-uipath.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ jobs:
image: ghcr.io/astral-sh/uv:python3.12-bookworm
env:
UIPATH_JOB_KEY: "3a03d5cb-fa21-4021-894d-a8e2eda0afe0"
UIPATH_TRACING_ENABLED: false
Comment on lines 89 to +91
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UIPATH_TRACING_ENABLED is set here, but in this repo it appears to be parsed and then never applied (see UiPathRuntimeContext.with_defaults in src/uipath/runtime/context.py, where tracing_enabled is computed but not assigned to the context or used to conditionally create/disable a trace manager). Unless another component reads this env var directly, this workflow change likely won’t actually disable tracing for the integration tests. Consider wiring the env var into trace manager initialization (or removing tracing setup when disabled) and/or updating the workflow to use the env var that the tracing implementation actually honors.

Copilot uses AI. Check for mistakes.
permissions:
contents: read
strategy:
Expand Down