Skip to content

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented Jan 13, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/64496


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sabernhardt, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment on lines +1017 to +1019
if ( ! is_int( $time ) || gmdate( 'Y', $time ) !== $year ) {
/* translators: Date and time format for recent posts on the dashboard, from a different calendar year, see https://www.php.net/manual/datetime.format.php */
$relative = date_i18n( __( 'M jS Y' ), $time );

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach silences the error and shows date information, but the date is not reliable with non-integers.

  • The numeric string with Simple Location displayed as the next day for two of my posts.
  • date_i18n() will give the current date whenever its $timestamp_with_offset parameter is not numeric.
screenshots of Activity widget with PR 10729

I still think that blank space is better than displaying inaccurate information, but this achieves the main focus of the ticket by preventing a predictable fatal error. PHP 8.4.0 does not complain (yet) about using a false value from get_the_time() in the '%1$s, %2$s' string on line 1036.


I needed to include results for at least one of the date translation plugins, and WP-Parsidate filters get_the_time well. It returns an integer when the format is 'U', so it does not cause an error in the widget before or after applying either patch. It also returns the Persian time and date strings for displaying in the widget.

(Both the 'Change Locale in admin' and 'Shamsi date' checkboxes should be checked.)
WP-Parsidate Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants