-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix: Type Error with gmdate() in dashboard Activity widget #10729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| if ( ! is_int( $time ) || gmdate( 'Y', $time ) !== $year ) { | ||
| /* translators: Date and time format for recent posts on the dashboard, from a different calendar year, see https://www.php.net/manual/datetime.format.php */ | ||
| $relative = date_i18n( __( 'M jS Y' ), $time ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach silences the error and shows date information, but the date is not reliable with non-integers.
- The numeric string with Simple Location displayed as the next day for two of my posts.
date_i18n()will give the current date whenever its$timestamp_with_offsetparameter is not numeric.
I still think that blank space is better than displaying inaccurate information, but this achieves the main focus of the ticket by preventing a predictable fatal error. PHP 8.4.0 does not complain (yet) about using a false value from get_the_time() in the '%1$s, %2$s' string on line 1036.
I needed to include results for at least one of the date translation plugins, and WP-Parsidate filters get_the_time well. It returns an integer when the format is 'U', so it does not cause an error in the widget before or after applying either patch. It also returns the Persian time and date strings for displaying in the widget.
(Both the 'Change Locale in admin' and 'Shamsi date' checkboxes should be checked.)
Trac ticket: https://core.trac.wordpress.org/ticket/64496
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.