Skip to content

Fix: Type Error with gmdate() in dashboard Activity widget #10729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
westonruter wants to merge 15 commits into
base: trunk
Choose a base branch
from
Open

Fix: Type Error with gmdate() in dashboard Activity widget #10729

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
43f4a86
https://core.trac.wordpress.org/attachment/ticket/64496/64496.diff
sabernhardt Jan 13, 2026
102ad11
Show underlying return value for get_the_time() if relative fails
westonruter Jan 13, 2026
b42c718
Use full date as fallback
westonruter Jan 13, 2026
1253072
Combine conditions
westonruter Jan 13, 2026
add31fb
Revert "Combine conditions"
westonruter Jan 14, 2026
2aed48c
Revert "Use full date as fallback"
westonruter Jan 14, 2026
0870b45
Revert "Show underlying return value for get_the_time() if relative f…
westonruter Jan 14, 2026
238be31
Merge branch 'trunk' of https://github.com/WordPress/wordpress-develo…
westonruter Jan 14, 2026
ede1099
Reapply "Show underlying return value for get_the_time() if relative …
westonruter Jan 14, 2026
b8a4865
Reapply "Use full date as fallback"
westonruter Jan 14, 2026
96ba63b
Reapply "Combine conditions"
westonruter Jan 14, 2026
096cea0
Use get_the_date() when unable to obtain relative date
westonruter Jan 14, 2026
958ce5c
Remove needless null coalescing
westonruter Jan 14, 2026
d57f6b2
Rename variable since not specifically relative
westonruter Jan 14, 2026
eb1e6d9
Reuse shorter date format
westonruter Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/wp-admin/includes/dashboard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,16 +1014,19 @@ function wp_dashboard_recent_posts( $args ) {

$time = get_the_time( 'U' );

if ( gmdate( 'Y-m-d', $time ) === $today ) {
$relative = __( 'Today' );
if ( ! is_int( $time ) ) {
/* translators: Date and time format for recent posts on the dashboard, from a different calendar year, see https://www.php.net/manual/datetime.format.php */
$date = get_the_date( __( 'M jS Y' ) );
} elseif ( gmdate( 'Y-m-d', $time ) === $today ) {
$date = __( 'Today' );
} elseif ( gmdate( 'Y-m-d', $time ) === $tomorrow ) {
$relative = __( 'Tomorrow' );
$date = __( 'Tomorrow' );
} elseif ( gmdate( 'Y', $time ) !== $year ) {
/* translators: Date and time format for recent posts on the dashboard, from a different calendar year, see https://www.php.net/manual/datetime.format.php */
$relative = date_i18n( __( 'M jS Y' ), $time );
$date = date_i18n( __( 'M jS Y' ), $time );
} else {
/* translators: Date and time format for recent posts on the dashboard, see https://www.php.net/manual/datetime.format.php */
$relative = date_i18n( __( 'M jS' ), $time );
$date = date_i18n( __( 'M jS' ), $time );
}

// Use the post edit link for those who can edit, the permalink otherwise.
Expand All @@ -1033,7 +1036,7 @@ function wp_dashboard_recent_posts( $args ) {
printf(
'<li><span>%1$s</span> <a href="%2$s" aria-label="%3$s">%4$s</a></li>',
/* translators: 1: Relative date, 2: Time. */
sprintf( _x( '%1$s, %2$s', 'dashboard' ), $relative, get_the_time() ),
sprintf( _x( '%1$s, %2$s', 'dashboard' ), $date, get_the_time() ),
$recent_post_link,
/* translators: %s: Post title. */
esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $draft_or_post_title ) ),
Expand Down
Loading