-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add hash handling to site health accordions - Refreshing 8184.diff #9176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Add hash handling to site health accordions - Refreshing 8184.diff #9176
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| } ); | ||
|
|
||
| /* global setTimeout */ | ||
| wp.domReady( function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be sufficient for async tests which run after the page has loaded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@westonruter No, wp.domReady() only waits for the DOM to be ready (like DOMContentLoaded), not for async content or tests that run after the page has loaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So then isn't this running too early? It should run after all of the async tests have completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Site Tools > Info tab data is loaded statically, so there aren't any async tests involved. In this case, wp.domReady() is fine to use. Existing test reports also show no issues, so it seems to be working as expected.
Are you seeing any problem with it?
Trac ticket: https://core.trac.wordpress.org/ticket/62846
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.