Skip to content

Add hash handling to site health accordions - Refreshing 8184.diff #9176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikunj8866 wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Add hash handling to site health accordions - Refreshing 8184.diff #9176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04e24d2
Add hash handling to site health accordions
nikunj8866 Jul 1, 2025
8117bd1
Replace setTimeout with the wp.domReady
nikunj8866 Jul 2, 2025
b29c1d3
Remove hash click for the Status tab
nikunj8866 Jul 3, 2025
0f8ad0d
Merge branch 'trunk' into 62846-add-hash-handling-to-site-health-acco…
nikunj8866 Oct 13, 2025
4431526
changes suggested by westonruter
nikunj8866 Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/js/_enqueues/admin/site-health.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ jQuery( function( $ ) {
$( '.health-check-accordion' ).on( 'click', '.health-check-accordion-trigger', function() {
var isExpanded = ( 'true' === $( this ).attr( 'aria-expanded' ) );

if ( $( this ).prop( 'id' ) ) {
window.location.hash = $( this ).prop( 'id' );
}

if ( isExpanded ) {
$( this ).attr( 'aria-expanded', 'false' );
$( '#' + $( this ).attr( 'aria-controls' ) ).attr( 'hidden', true );
Expand All @@ -53,6 +57,20 @@ jQuery( function( $ ) {
}
} );

/* global setTimeout */
wp.domReady( function() {
Copy link
Member

@westonruter westonruter Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be sufficient for async tests which run after the page has loaded?

Copy link
Author

@nikunj8866 nikunj8866 Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter No, wp.domReady() only waits for the DOM to be ready (like DOMContentLoaded), not for async content or tests that run after the page has loaded.

Copy link
Member

@westonruter westonruter Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So then isn't this running too early? It should run after all of the async tests have completed.

Copy link
Author

@nikunj8866 nikunj8866 Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Site Tools > Info tab data is loaded statically, so there aren't any async tests involved. In this case, wp.domReady() is fine to use. Existing test reports also show no issues, so it seems to be working as expected.

Are you seeing any problem with it?

// Get hash from query string and open the related accordion.
var hash = window.location.hash;

if ( hash ) {
var requestedPanel = $( hash );

if ( requestedPanel.is( '.health-check-accordion-trigger' ) ) {
requestedPanel.trigger( 'click' );
}
}
} );

// Site Health test handling.

$( '.site-health-view-passed' ).on( 'click', function() {
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/site-health-info.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@

?>
<h3 class="health-check-accordion-heading">
<button aria-expanded="false" class="health-check-accordion-trigger" aria-controls="health-check-accordion-block-<?php echo esc_attr( $section ); ?>" type="button">
<button id="health-check-section-<?php echo esc_attr( $section ); ?>" aria-expanded="false" class="health-check-accordion-trigger" aria-controls="health-check-accordion-block-<?php echo esc_attr( $section ); ?>" type="button">
<span class="title">
<?php echo esc_html( $details['label'] ); ?>
<?php
Expand Down
Loading