Users: Fix Generate Password button requiring two clicks on Add New User screen#9674
Users: Fix Generate Password button requiring two clicks on Add New User screen#9674taninakond wants to merge 4 commits intoWordPress:trunkfrom
Conversation
…e password field on the Add New User screen. The password was previously set before the AJAX response returned, resulting in the first click not updating the password field. This change moves the `generatePassword()` call inside the AJAX callback to ensure the password is always updated immediately. Props taninahmed. Fixes #63897.
|
Hi @taninakond! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Move the block at lines 264–268 to line 63, directly under the generatePassword call. This ensures that:
1. The password field is always initialized with the value set in $pass1.data('pw'), which comes from PHP and is set at line 32.
2. Any network request to fetch a new password happens after the initial password is set, so there is no delay in showing a password on page load.
3. When the user clicks the "Generate Password" button, a new password is fetched and stored in data-pw, ensuring the latest password is always available.
The block at lines 533–542 that triggered the "Generate Password" button click on page load is no longer needed. Passwords are already automatically filled via the bindPass1 function, which calls generatePassword() on initialization.
Refactor automatic password generation for improved UX and code clarity on the Add New User and Reset Password pagesRemove redundant code: Move network password generation:
Result: |
Wrap the `generate-password` AJAX call in a conditional check to ensure it only runs when the `.wp-generate-pw` element is present. This avoids unnecessary requests on pages such as: - Settings → Writing - Installer "Information needed" screen (which could result in 404 errors)
1 participant
This patch fixes the issue where the Generate Password button requires two clicks on the Add New User screen.
generatePassword()inside the AJAX callback.Trac ticket: https://core.trac.wordpress.org/ticket/63897
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.