Skip to content

Users: Fix Generate Password button requiring two clicks on Add New User screen #9674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taninakond wants to merge 4 commits into
base: trunk
Choose a base branch
from
+8 −18
Open

Users: Fix Generate Password button requiring two clicks on Add New User screen #9674

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
877bf3d
Users: Fix Generate Password button requiring two clicks to update th…
taninakond Aug 29, 2025
17f7e95
Move network password generation
taninakond Aug 31, 2025
eb420ba
Remove redundant code
taninakond Aug 31, 2025
a0a7f93
Prevent unnecessary AJAX requests for password generation
taninakond Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions src/js/_enqueues/admin/user-profile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,14 @@
if ( 'mailserver_pass' !== $pass1.prop('id' ) && ! $('#weblog_title').length ) {
$( $pass1 ).trigger( 'focus' );
}

if($( '.wp-generate-pw').length) {
// Generate the next password and cache.
wp.ajax.post( 'generate-password' )
.done( function( data ) {
$pass1.data( 'pw', data );
} );
}
}

function bindPass1() {
Expand Down Expand Up @@ -260,12 +268,6 @@

// Show generated password in plaintext by default.
resetToggle ( false );

// Generate the next password and cache.
wp.ajax.post( 'generate-password' )
.done( function( data ) {
$pass1.data( 'pw', data );
} );
} );

$cancelButton = $pass1Row.find( 'button.wp-cancel-pw' );
Expand Down Expand Up @@ -529,16 +531,4 @@
return __( 'The changes you made will be lost if you navigate away from this page.' );
}
});

/*
* We need to generate a password as soon as the Reset Password page is loaded,
* to avoid double clicking the button to retrieve the first generated password.
* See ticket #39638.
*/
$( function() {
if ( $( '.reset-pass-submit' ).length ) {
$( '.reset-pass-submit button.wp-generate-pw' ).trigger( 'click' );
}
});

})(jQuery);
Loading