Skip to content

Conversation

@ttypic
Copy link
Contributor

@ttypic ttypic commented Oct 30, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where async requests were not handled after the realtime client reconnected following a manual disconnect
  • Chores

    • Bumped release to 1.4.2 across build config, docs, README, and dependency examples
    • Added 1.4.2 entry to the changelog and updated test version references to match the new release

@ttypic ttypic requested a review from AndyTWF October 30, 2025 14:31
@coderabbitai
Copy link

coderabbitai bot commented Oct 30, 2025

Walkthrough

Version 1.4.2 release bump: updated version strings in build metadata, docs, and a test; added a CHANGELOG entry noting a fix for async requests after realtime client reconnection following a manual close.

Changes

Cohort / File(s) Summary
Version Configuration
gradle.properties
Updated VERSION_NAME from 1.4.1 to 1.4.2.
Documentation & Changelog
CHANGELOG.md, CONTRIBUTING.md, README.md
Added 1.4.2 release entry describing a fix; updated dependency examples and Android AAR/Gradle/Maven/OkHttp version strings from 1.4.1 to 1.4.2.
Tests
lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java
Updated expected agent/version string from ably-java/1.4.1 to ably-java/1.4.2.

Sequence Diagram(s)

(omitted — changes are version/documentation/test updates; no control-flow or feature code changes to visualize)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Changes are consistent version-string and documentation updates.
  • Files to spot-check: RealtimeHttpHeaderTest.java (assertion update) and CHANGELOG.md (accurate wording of the fix).

Poem

🐰 A tiny hop to 1.4.2,
Docs and tests all updated true,
A changelog line, a fix in sight,
Version strings aligned and tight,
I nibble bugs and dance with delight.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Release/1.4.2" directly and clearly describes the main purpose of this changeset. All modifications in the PR are version-related updates—bumping version numbers in gradle.properties, README.md, CONTRIBUTING.md, and updating the CHANGELOG.md with release notes for 1.4.2, plus corresponding test expectations. The title is specific, concise, and accurately reflects that this is a release PR for version 1.4.2, which would be immediately clear to someone scanning the commit history.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/1.4.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot temporarily deployed to staging/pull/1178/features October 30, 2025 14:32 Inactive
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 73e2449 and 050206d.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
CHANGELOG.md

9-9: Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: check (29)
  • GitHub Check: check (24)
  • GitHub Check: check (19)
  • GitHub Check: check (29)
  • GitHub Check: check (21)
  • GitHub Check: check
  • GitHub Check: build
  • GitHub Check: check-realtime
  • GitHub Check: check-rest
  • GitHub Check: check-liveobjects
  • GitHub Check: check-realtime-okhttp
  • GitHub Check: check-rest-okhttp
🔇 Additional comments (1)
CHANGELOG.md (1)

3-9: Release entry structure is sound.

The v1.4.2 entry follows the established format of prior release entries (compare with v1.4.1 at lines 11–20), with a version tag link, full changelog comparison link, and "What's Changed" section. Once the URL formatting is corrected, this release notes entry will be complete.

Comment on lines +3 to +9
## [1.4.2](https://github.com/ably/ably-java/tree/v1.4.2)

[Full Changelog](https://github.com/ably/ably-java/compare/v1.4.1...v1.4.2)

### What's Changed

* Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in https://github.com/ably/ably-java/pull/1176
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Convert bare URL to markdown link format for consistency.

Line 9 contains a bare URL that violates markdown standards and deviates from the changelog's established conventions. Other entries use markdown link format (e.g., [\#1176](https://github.com/ably/ably-java/pull/1176)) to reference pull requests. Standardize this entry to match.

Apply this diff to fix the formatting:

* Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in https://github.com/ably/ably-java/pull/1176
+ * Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in [\#1176](https://github.com/ably/ably-java/pull/1176)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## [1.4.2](https://github.com/ably/ably-java/tree/v1.4.2)
[Full Changelog](https://github.com/ably/ably-java/compare/v1.4.1...v1.4.2)
### What's Changed
* Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in https://github.com/ably/ably-java/pull/1176
## [1.4.2](https://github.com/ably/ably-java/tree/v1.4.2)
[Full Changelog](https://github.com/ably/ably-java/compare/v1.4.1...v1.4.2)
### What's Changed
* Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in [\#1176](https://github.com/ably/ably-java/pull/1176)
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

9-9: Bare URL used

(MD034, no-bare-urls)

🤖 Prompt for AI Agents
In CHANGELOG.md around lines 3 to 9, the pull request reference is a bare URL;
replace the bare URL with a markdown link in the changelog's established format
(e.g., change the trailing "https://github.com/ably/ably-java/pull/1176" to
"[#1176](https://github.com/ably/ably-java/pull/1176)") so the entry matches
other entries' markdown link style.

@ttypic ttypic merged commit 4f354a8 into main Oct 30, 2025
14 checks passed
@ttypic ttypic deleted the release/1.4.2 branch October 30, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants