-
Notifications
You must be signed in to change notification settings - Fork 41
Release/1.4.2 #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.4.2 #1178
Conversation
WalkthroughVersion 1.4.2 release bump: updated version strings in build metadata, docs, and a test; added a CHANGELOG entry noting a fix for async requests after realtime client reconnection following a manual close. Changes
Sequence Diagram(s)(omitted — changes are version/documentation/test updates; no control-flow or feature code changes to visualize) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
CHANGELOG.md
9-9: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: check (29)
- GitHub Check: check (24)
- GitHub Check: check (19)
- GitHub Check: check (29)
- GitHub Check: check (21)
- GitHub Check: check
- GitHub Check: build
- GitHub Check: check-realtime
- GitHub Check: check-rest
- GitHub Check: check-liveobjects
- GitHub Check: check-realtime-okhttp
- GitHub Check: check-rest-okhttp
🔇 Additional comments (1)
CHANGELOG.md (1)
3-9: Release entry structure is sound.The v1.4.2 entry follows the established format of prior release entries (compare with v1.4.1 at lines 11–20), with a version tag link, full changelog comparison link, and "What's Changed" section. Once the URL formatting is corrected, this release notes entry will be complete.
| ## [1.4.2](https://github.com/ably/ably-java/tree/v1.4.2) | ||
|
|
||
| [Full Changelog](https://github.com/ably/ably-java/compare/v1.4.1...v1.4.2) | ||
|
|
||
| ### What's Changed | ||
|
|
||
| * Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in https://github.com/ably/ably-java/pull/1176 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convert bare URL to markdown link format for consistency.
Line 9 contains a bare URL that violates markdown standards and deviates from the changelog's established conventions. Other entries use markdown link format (e.g., [\#1176](https://github.com/ably/ably-java/pull/1176)) to reference pull requests. Standardize this entry to match.
Apply this diff to fix the formatting:
* Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in https://github.com/ably/ably-java/pull/1176
+ * Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in [\#1176](https://github.com/ably/ably-java/pull/1176)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## [1.4.2](https://github.com/ably/ably-java/tree/v1.4.2) | |
| [Full Changelog](https://github.com/ably/ably-java/compare/v1.4.1...v1.4.2) | |
| ### What's Changed | |
| * Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in https://github.com/ably/ably-java/pull/1176 | |
| ## [1.4.2](https://github.com/ably/ably-java/tree/v1.4.2) | |
| [Full Changelog](https://github.com/ably/ably-java/compare/v1.4.1...v1.4.2) | |
| ### What's Changed | |
| * Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in [\#1176](https://github.com/ably/ably-java/pull/1176) |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
9-9: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 3 to 9, the pull request reference is a bare URL;
replace the bare URL with a markdown link in the changelog's established format
(e.g., change the trailing "https://github.com/ably/ably-java/pull/1176" to
"[#1176](https://github.com/ably/ably-java/pull/1176)") so the entry matches
other entries' markdown link style.
Summary by CodeRabbit
Bug Fixes
Chores