Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Change Log

## [1.4.2](https://github.com/ably/ably-java/tree/v1.4.2)

[Full Changelog](https://github.com/ably/ably-java/compare/v1.4.1...v1.4.2)

### What's Changed

* Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in https://github.com/ably/ably-java/pull/1176
Comment on lines +3 to +9
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Convert bare URL to markdown link format for consistency.

Line 9 contains a bare URL that violates markdown standards and deviates from the changelog's established conventions. Other entries use markdown link format (e.g., [\#1176](https://github.com/ably/ably-java/pull/1176)) to reference pull requests. Standardize this entry to match.

Apply this diff to fix the formatting:

* Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in https://github.com/ably/ably-java/pull/1176
+ * Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in [\#1176](https://github.com/ably/ably-java/pull/1176)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## [1.4.2](https://github.com/ably/ably-java/tree/v1.4.2)
[Full Changelog](https://github.com/ably/ably-java/compare/v1.4.1...v1.4.2)
### What's Changed
* Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in https://github.com/ably/ably-java/pull/1176
## [1.4.2](https://github.com/ably/ably-java/tree/v1.4.2)
[Full Changelog](https://github.com/ably/ably-java/compare/v1.4.1...v1.4.2)
### What's Changed
* Fixed an issue where async requests were not working after the realtime client reconnected following a manual close in [\#1176](https://github.com/ably/ably-java/pull/1176)
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

9-9: Bare URL used

(MD034, no-bare-urls)

🤖 Prompt for AI Agents
In CHANGELOG.md around lines 3 to 9, the pull request reference is a bare URL;
replace the bare URL with a markdown link in the changelog's established format
(e.g., change the trailing "https://github.com/ably/ably-java/pull/1176" to
"[#1176](https://github.com/ably/ably-java/pull/1176)") so the entry matches
other entries' markdown link style.


## [1.4.1](https://github.com/ably/ably-java/tree/v1.4.1)

[Full Changelog](https://github.com/ably/ably-java/compare/v1.4.0...v1.4.1)
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ You may wish to make changes to Ably Java or Ably Android, and test it immediate
- Open the directory printed from the output of that command. Inside that folder, get the `ably-android-x.y.z.aar`, and place it your Android project's `libs/` directory. Create this directory if it doesn't exist.
- Add an `implementation` dependency on the `.aar`:
```groovy
implementation files('libs/ably-android-1.4.1.aar')
implementation files('libs/ably-android-1.4.2.aar')
```
- Add the `implementation` (not `testImplementation`) dependencies found in `dependencies.gradle` to your project. This is because the `.aar` does not contain dependencies.
- Build/run your application.
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ The Java SDK is available as a [Maven dependency](https://mvnrepository.com/arti
<dependency>
<groupId>io.ably</groupId>
<artifactId>ably-java</artifactId>
<version>1.4.1</version>
<version>1.4.2</version>
</dependency>
```

### Install for Gradle:

```gradle
implementation 'io.ably:ably-java:1.4.1'
implementation 'io.ably:ably-java:1.4.2'
implementation 'org.slf4j:slf4j-simple:2.0.7'
```

Expand Down Expand Up @@ -113,7 +113,7 @@ Add the following dependency to your `build.gradle` file:

```groovy
dependencies {
runtimeOnly("io.ably:liveobjects:1.4.1")
runtimeOnly("io.ably:liveobjects:1.4.2")
}
```

Expand All @@ -140,7 +140,7 @@ Add the following dependency to your `build.gradle` file:

```groovy
dependencies {
runtimeOnly("io.ably:network-client-okhttp:1.4.1")
runtimeOnly("io.ably:network-client-okhttp:1.4.2")
}
```

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
GROUP=io.ably
VERSION_NAME=1.4.1
VERSION_NAME=1.4.2
POM_INCEPTION_YEAR=2015
POM_URL=https://github.com/ably/ably-java
POM_SCM_URL=https://github.com/ably/ably-java/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public void realtime_websocket_param_test() {
* Defaults.ABLY_AGENT_PARAM, as ultimately the request param has been derived from those values.
*/
assertEquals("Verify correct lib version", requestParameters.get("agent"),
Collections.singletonList("ably-java/1.4.1 jre/" + System.getProperty("java.version")));
Collections.singletonList("ably-java/1.4.2 jre/" + System.getProperty("java.version")));

/* Spec RTN2a */
assertEquals("Verify correct format", requestParameters.get("format"),
Expand Down
Loading