fix: all event target for shadow dom #9551
Merged
+688
−228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
5 tasks
reidbarber
previously approved these changes
Jan 29, 2026
|
Build successful! 🎉 |
|
Build successful! 🎉 |
5 tasks
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
previously approved these changes
Feb 6, 2026
Member
devongovett
left a comment
devongovett
left a comment
There was a problem hiding this comment.
Maybe we can make a helper function for this pattern: nodeContains(e.currentTarget, getEventTarget(e)), seems super common.
reidbarber
previously approved these changes
Feb 9, 2026
# Conflicts: # packages/@react-aria/utils/src/useViewportSize.ts
snowystinger
dismissed stale reviews from reidbarber and devongovett
via
47111d7
# Conflicts: # eslint.config.mjs # packages/@react-aria/calendar/src/useCalendarCell.ts # packages/@react-aria/dnd/src/DragManager.ts # packages/@react-aria/grid/src/useGridCell.ts # packages/@react-aria/gridlist/src/useGridListItem.ts # packages/@react-aria/interactions/src/useFocusVisible.ts # packages/@react-aria/interactions/src/utils.ts # packages/@react-aria/menu/src/useSubmenuTrigger.ts # packages/@react-aria/overlays/src/usePreventScroll.ts # packages/@react-aria/selection/src/useSelectableCollection.ts # packages/@react-aria/selection/src/useSelectableItem.ts # packages/@react-aria/toolbar/src/useToolbar.ts # packages/@react-aria/utils/src/useViewportSize.ts # packages/dev/eslint-plugin-rsp-rules/index.js
|
Build successful! 🎉 |
## API Changes
@react-aria/utils/@react-aria/utils:getEventTarget-getEventTarget <T extends Event> {
+getEventTarget <T extends Event | SyntheticEvent> {
event: T
returnVal: undefined
}/@react-aria/utils:nodeContains nodeContains {
- node: Node | null | undefined
- otherNode: Node | null | undefined
+ node: Node | Element | null | undefined
+ otherNode: Node | Element | null | undefined
returnVal: undefined
} |
reidbarber
approved these changes
Feb 9, 2026
LFDanLu
approved these changes
Feb 9, 2026
snowystinger
deleted the
alternate-fix-all-event-target-for-shadow-dom
branch
This was referenced Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another bulk fix for shadow dom, this lints for event.target and auto fixes to getEventTarget(event) which just defers to event.target under the hood.
Some events are not affected when I could detect that the event was one of our Press events or Drag/Drop events since those don't match native events and don't have the same kinds of properties. Those may eventually need different updates.
Some of these updates were done here:
#8991
This PR should make reviewing other ShadowDOM PRs easier and prevent us from regressing
Follow up to #9485
Replaces #9486
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: