fix(core): reject queued loop callbacks on cancel#14566
Open
neriousy wants to merge 3 commits intoanomalyco:devfrom
Open
fix(core): reject queued loop callbacks on cancel#14566neriousy wants to merge 3 commits intoanomalyco:devfrom
neriousy wants to merge 3 commits intoanomalyco:devfrom
Conversation
neriousy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #14565
Type of change
What does this PR do?
Fixes a hang where concurrent callers waiting on
SessionPrompt.loop()could wait forever if the session is cancelled (or the Instance is disposed) while callbacks are queued.How did you verify your code works?
Run the added tests
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.